[cpullvm] xfail libunwind test dwarf_expression_stack.pass.cpp - #661
Open
Jonathon Penix (jonathonpenix) wants to merge 2 commits into
Open
[cpullvm] xfail libunwind test dwarf_expression_stack.pass.cpp#661Jonathon Penix (jonathonpenix) wants to merge 2 commits into
Jonathon Penix (jonathonpenix) wants to merge 2 commits into
Conversation
This explicitly uses fork() and waitpid() which I don't think are supported by picolibc for our embedded targets. So just xfail the test. Right now this only impacts our AArch64 variants, but just xfail it for everything since all of our Arm/AArch64/RISC-V variants would have the same issue. Signed-off-by: Jonathon Penix <jpenix@qti.qualcomm.com>
Jonathon Penix (jonathonpenix)
requested review from
Ana Pazos (apazos),
Eli Friedman (efriedma-quic) and
pranav4330
September 8, 2026 23:27
Ana Pazos (apazos)
approved these changes
Sep 8, 2026
Eli Friedman (efriedma-quic)
left a comment
Eli Friedman (efriedma-quic)
left a comment
Contributor
There was a problem hiding this comment.
I'm okay with this, but we should open a bug upstream. (It looks like this test was added in llvm/llvm-project#220662 ?)
Contributor
Author
|
I'm not opposed to filing something upstream, but I guess what are we hoping to get at with the bug? Are we looking for a better way to keep these sorts of tests (that use fork(), etc.) isolated so we don't have to xfail them? Or something else? As far as I can tell there's nothing really going wrong here, it's just that we're running the test in an environment where fork() etc. isn't (will probably never be?) supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This explicitly uses fork() and waitpid() which I don't think are supported by picolibc for our embedded targets. So just xfail the test.
Right now this only impacts our AArch64 variants, but just xfail it for everything since all of our Arm/AArch64/RISC-V variants would have the same issue.