[cpullvm] Unify Linux AArch64 Host Compiler to Clang 22.1.8 on GitHub Ubuntu Runner - #625
Conversation
| # | ||
| # Other build configurations such as building the runtimes on non-Linux | ||
| # x86_64 platforms are built and tested separately. | ||
| # clang-22 for linux aarch64 github runner. |
There was a problem hiding this comment.
If this is just a temporary change to trigger the workflow, that is fine--please just make sure it is removed once the build completes/before merging.
Otherwise, please remove this--it isn't providing any particularly helpful information and keeping this updated is just going to be noise.
There was a problem hiding this comment.
yes its a temporary change
| sudo apt-get update | ||
| # Install swig and libedit-dev used by lldb and | ||
| # libc++-dev required for eld tests | ||
| sudo apt-get install -y swig libedit-dev clang-19 libc++-19-dev | ||
| sudo apt-get install -y swig libedit-dev clang-22 libc++-22-dev |
There was a problem hiding this comment.
I wonder if we're missing lld here--see the /usr/bin/ld warnings in the AArch64 build
This might be fixed by using the install script as I think it'll pull everything if not otherwise specified.
There was a problem hiding this comment.
I think default ld is being picked up so i will add lld-22
There was a problem hiding this comment.
Hm, still seeing the /usr/bin/ld warnings
pranav4330
changed the title
7ea2b95 to
7f1b105
Compare
| @@ -1,14 +1,24 @@ | |||
| # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. | |||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Shall we define CLANG_VERSION=22 and refer to it as ${CLANG_VERSION}?
There was a problem hiding this comment.
I think its not necessary, as this is working as expected.
There was a problem hiding this comment.
I think it is a good suggestion--next time we update versions we only need to update one spot.
There was a problem hiding this comment.
thanks for suggesting srilakshmi yalamaraju (@sriyalamar) I have made that change.
| @@ -1,14 +1,24 @@ | |||
| # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. | |||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I think it is a good suggestion--next time we update versions we only need to update one spot.
…buntu Runner Align the Linux AArch64 GitHub Ubuntu runner with the host compiler version used across other build environments. This change installs and uses Clang 22.1.8 on the GitHub-hosted AArch64 Ubuntu runner, ensuring consistent compiler versions across all supported build configurations and reducing toolchain-related variations. Signed-off-by: Pranav Patil <pranpati@qti.qualcomm.com>
7f1b105 to
03e56a2
Compare
|
hello Jonathon Penix (@jonathonpenix) i have made the changes can you check if i missed something, also Navaneeth Shanmugasundaram (@navaneethshan) can you look at this as well? |
There was a problem hiding this comment.
One last nit, but otherwise this should be close.
When fixing whatever is changing in the meson line, I think you can remove the test change in nightly.yml to prepare for merging.
Added a nit, but I think it is also a bit concerning we're still seeing the /usr/bin/ld warnings--seems like something still is off.
|
|
||
| # Install meson. eld support was added in v1.9.0, so we need at least that. | ||
| pip install meson==1.10.0 | ||
| pip install meson==1.10.0 |
There was a problem hiding this comment.
It looks like something weird is going on with whitespace--please remove this change
(probably some line ending or invisible characters?)
3 participants
Align the Linux AArch64 GitHub Ubuntu runner with the host compiler version used across other build environments.
This change installs and uses Clang 22.1.8 on the GitHub-hosted AArch64 Ubuntu runner, ensuring consistent compiler versions across all supported build configurations and reducing toolchain-related variations.