Skip to content

Conversation

@Marius1311
Copy link
Member

Jaccard can get memory-intensive for large datasets and large neighborhoods. This PR enabled batched mode-computation of jaccard to avoid memory issues.

@codecov
Copy link

codecov bot commented Jul 29, 2025

Codecov Report

❌ Patch coverage is 88.33333% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.85%. Comparing base (041ce94) to head (3eb057e).

Files with missing lines Patch % Lines
src/cellmapper/model/kernel.py 60.00% 4 Missing ⚠️
src/cellmapper/utils.py 95.45% 2 Missing ⚠️
src/cellmapper/model/mapping_operator.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   87.78%   87.85%   +0.06%     
==========================================
  Files          13       13              
  Lines        1187     1235      +48     
==========================================
+ Hits         1042     1085      +43     
- Misses        145      150       +5     
Files with missing lines Coverage Δ
src/cellmapper/_docs.py 100.00% <100.00%> (ø)
src/cellmapper/constants.py 100.00% <100.00%> (ø)
src/cellmapper/model/cellmapper.py 86.49% <ø> (ø)
src/cellmapper/model/mapping_operator.py 94.62% <66.66%> (-0.52%) ⬇️
src/cellmapper/utils.py 95.23% <95.45%> (+0.03%) ⬆️
src/cellmapper/model/kernel.py 87.68% <60.00%> (-1.37%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Marius1311
Copy link
Member Author

TODO

  • fix logging
  • make sure the warnings are issued correctly.
  • test actual memory savings.

@Marius1311
Copy link
Member Author

Looks like this isn't actually memory efficient, I need to find a different solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants