Merge pull request #714 from qsb-dev/dev

Dev

Author: JohnCorby

QSB/manifest.json

@@ -4,7 +4,7 @@
 	"author": "Nebula, John, Alek, & Rai",
 	"name": "Quantum Space Buddies",
 	"uniqueName": "Raicuparta.QuantumSpaceBuddies",
-	"version": "1.4.1",
+	"version": "1.4.2",
 	"owmlVersion": "2.14.0",
 	"dependencies": [ "JohnCorby.VanillaFix" ],
 	"pathsToPreserve": [ "debugsettings.json" ],

SteamTransport/Client.cs

@@ -135,7 +135,7 @@ public void Close()
 		IsConnected = false;
 		// its not an error for us to close ourselves intentionally
 		// but we do it anyway cuz above comment
-		_transport.OnClientError?.Invoke(TransportError.ConnectionClosed, "client closed connection, but you shouldnt be seeing this in game. make sure [DEBUG] Debug Mode is on and check logs for stack trace. report this please!");
+		_transport.OnClientError?.Invoke(TransportError.ConnectionClosed, "client closed connection for unknown reason! turn on \"[DEBUG] Debug Mode\" and \"[DEBUG] Hook Debug Logs\", try again, and report all logs shown!");
 		_transport.OnClientDisconnected?.Invoke();
 
 		_onStatusChanged.Dispose();

SteamTransport/Server.cs

@@ -103,8 +103,8 @@ public void Receive()
 	{
 		var ppOutMessages = new IntPtr[Util.MaxMessages];
 
-		var connList = _conns.ToList();
-		foreach (var conn in connList)
+		// receive can result in disconnect, which modifies the collection. we must copy
+		foreach (var conn in _conns.ToList())
 		{
 			var numMessages = SteamNetworkingSockets.ReceiveMessagesOnConnection(conn, ppOutMessages, ppOutMessages.Length);
 			for (var i = 0; i < numMessages; i++)
@@ -117,8 +117,7 @@ public void Receive()
 
 	public void Flush()
 	{
-		var connList = _conns.ToList();
-		foreach (var conn in connList)
+		foreach (var conn in _conns)
 		{
 			var result = SteamNetworkingSockets.FlushMessagesOnConnection(conn);
 			if (result != EResult.k_EResultOK)