okay actually do make copy

JohnCorby · JohnCorby · commit 600b00bb7f2a · 2025-02-27T20:15:27.000-08:00
diff --git a/SteamTransport/Server.cs b/SteamTransport/Server.cs
@@ -2,6 +2,7 @@
 using Steamworks;
 using System;
 using System.Collections.Generic;
+using System.Linq;
 
 namespace SteamTransport;
 
@@ -102,7 +103,8 @@ public void Receive()
 	{
 		var ppOutMessages = new IntPtr[Util.MaxMessages];
 
-		foreach (var conn in _conns)
+		// receive can result in disconnect, which modifies the collection. we must copy
+		foreach (var conn in _conns.ToList())
 		{
 			var numMessages = SteamNetworkingSockets.ReceiveMessagesOnConnection(conn, ppOutMessages, ppOutMessages.Length);
 			for (var i = 0; i < numMessages; i++)

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`	`using Steamworks;`
`3`	`3`	`using System;`
`4`	`4`	`using System.Collections.Generic;`
	`5`	`+using System.Linq;`
`5`	`6`
`6`	`7`	`namespace SteamTransport;`
`7`	`8`
`@@ -102,7 +103,8 @@ public void Receive()`
`102`	`103`	`{`
`103`	`104`	`var ppOutMessages = new IntPtr[Util.MaxMessages];`
`104`	`105`
`105`		`- foreach (var conn in _conns)`
	`106`	`+ // receive can result in disconnect, which modifies the collection. we must copy`
	`107`	`+ foreach (var conn in _conns.ToList())`
`106`	`108`	`{`
`107`	`109`	`var numMessages = SteamNetworkingSockets.ReceiveMessagesOnConnection(conn, ppOutMessages, ppOutMessages.Length);`
`108`	`110`	`for (var i = 0; i < numMessages; i++)`