Storing error messages in db

[sumant-rana]

User description

Store error_summary from a failed test in database for future reference and executing a repair loop outside the core test generation process.

---

PR Type

Enhancement

---

Description

• Store error summaries from failed tests in database

• Fix Java class pattern matching for records and templates

• Improve line number handling in test insertion

• Refactor error message extraction method signature

---

Diagram Walkthrough

flowchart LR
  A["Failed Test"] --> B["Extract Error Message"]
  B --> C["Store in Database"]
  C --> D["Future Reference"]
  E["Java Source"] --> F["Improved Pattern Matching"]
  F --> G["Better Class Detection"]

Loading

File Walkthrough

	Relevant files
Enhancement	unit_test_db.py Add error summary database storage                                              cover_agent/unit_test_db.py Add error_summary column to database schema Update insert and retrieval methods to handle error summaries Modify data structures to include error information +3/-0      unit_test_validator.py Enhance error handling and test validation                              cover_agent/unit_test_validator.py Refactor extract_error_message method signature Store error summaries in failed test runs Fix line number boundary checking for test insertion Improve test file content handling +31/-15
Bug fix	coverage_processor.py Fix Java class pattern matching                                                    cover_agent/coverage_processor.py Update Java class pattern regex to handle modifiers Support record and template class detection Improve pattern matching for various class types +1/-2
Tests	test_unit_test_db.py Update tests for error summary feature                                      tests/test_unit_test_db.py Add test cases for error summary storage Update test data to include error summary field Verify database operations with new column +3/-0      test_unit_test_validator.py Update tests for refactored error extraction                          tests/test_unit_test_validator.py Update test calls to match new method signature Modify error message extraction test parameters Adapt tests for refactored method interface +6/-2
Miscellaneous	version.txt Version bump to 0.3.11                                                                      cover_agent/version.txt Bump version from 0.3.10 to 0.3.11 +1/-1

---

[qodo-merge-for-open-source]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Logic Error The error message extraction is called after the test file is rolled back to original content, but the processed_test variable still contains the modified content. This could lead to inconsistent error analysis since the file state doesn't match the processed content being analyzed. error_message = self.extract_error_message(processed_test, stdout, stderr) if error_message: logging.error(f"Error message summary:\n{error_message}") self.failed_test_runs.append( {"code": generated_test, "error_message": error_message} ) # Append failure details to the list Boundary Check The line number boundary check subtracts 1 when the insertion point equals file length, but this assumes 1-based indexing. Need to verify this aligns with how line numbers are used elsewhere in the codebase to avoid off-by-one errors. if relevant_line_number_to_insert_tests_after: file_len = len(test_file_content_numbered.splitlines()) if relevant_line_number_to_insert_tests_after == file_len: relevant_line_number_to_insert_tests_after -= 1 Regex Complexity The new Java class pattern regex is significantly more complex and may have performance implications or edge cases. The pattern attempts to handle templates with nested brackets which could cause catastrophic backtracking on malformed input. class_pattern = re.compile(r"^\s*(?:(?:public|private|protected|static|final|abstract)\s+)*(?:class|interface|record)\s+(\w+)(?:(?:<|\().*?(?:>|\)|$))?(?:\s+extends|\s+implements|\s*\{|$)")

[qodo-merge-for-open-source]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Fix boundary check logic The boundary check should also handle the case where the line number exceeds the file length, not just equals it. This prevents potential index out of bounds errors when the line number is greater than the file length. cover_agent/unit_test_validator.py [250-253] if relevant_line_number_to_insert_tests_after: file_len = len(test_file_content_numbered.splitlines()) - if relevant_line_number_to_insert_tests_after == file_len: - relevant_line_number_to_insert_tests_after -= 1 + if relevant_line_number_to_insert_tests_after >= file_len: + relevant_line_number_to_insert_tests_after = file_len - 1 Apply / Chat Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies a potential out-of-bounds error if the LLM returns a line number greater than the file length and provides a robust fix by changing == to >=.	Medium
Learned best practice	Fix regex template parameter matching The regex pattern has an issue with the template/generic parameter matching where (?:>|)|$))? allows the pattern to end prematurely with just $. This could cause incorrect matches when parsing Java class declarations with generic parameters. The pattern should ensure proper closing of template parameters before allowing other syntax elements. cover_agent/coverage_processor.py [310] -class_pattern = re.compile(r"^\s*(?:(?:public|private|protected|static|final|abstract)\s+)*(?:class|interface|record)\s+(\w+)(?:(?:<|\().*?(?:>|\)|$))?(?:\s+extends|\s+implements|\s*\{|$)") +class_pattern = re.compile(r"^\s*(?:(?:public|private|protected|static|final|abstract)\s+)*(?:class|interface|record)\s+(\w+)(?:(?:<|\().*?(?:>|\)))?(?:\s+extends|\s+implements|\s*\{|$)") Apply / Chat Suggestion importance[1-10]: 6 __ Why: Relevant best practice - Improve regex patterns for parsing code structures to handle edge cases, language variations, and complex syntax patterns	Low
Update