You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Black uses a line length of 88 by default, so this updates CONTRIBUTING.md accordingly. Alternatively, we could use a line length of 100; in this case, we would have to pass it as an argument to black in tox.ini.
I don't have a strong opinion, but I think there is a good case for 100. The applications modules seem to use that as the limit, set in each repository's pyproject.toml. (This probably makes more sense than doing it in tox.ini, as I suggested in the top post.)
I'm going to merge this, since our goal is to keep the template repository in a near-perfect state at all times. I'll add the commit that reverts this change to #46, so that everything will be consistent then too if we decide to change the line length to 100 and merge it.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Black uses a line length of 88 by default, so this updates
CONTRIBUTING.mdaccordingly. Alternatively, we could use a line length of 100; in this case, we would have to pass it as an argument toblackintox.ini.Details and comments