React.PropTypes will be deprecated#63
Open
jedkl15 wants to merge 50 commits intofeature/allow-width-overridefrom
Open
React.PropTypes will be deprecated#63jedkl15 wants to merge 50 commits intofeature/allow-width-overridefrom
jedkl15 wants to merge 50 commits intofeature/allow-width-overridefrom
Conversation
add to npm ignore
Fix invalid import syntax
allowed react 0.14 and 15.0
fix for react 15.2.0 props warnings
Signed-off-by: Qiming <qimingweng@users.noreply.github.com>
Fix for “Warning: Unknown prop `dismissOnBackgroundClick` on <div> tag. Remove this prop from the element.”
Fix for unknown prop warning
sending event when onClose is triggered
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello qimingweng
React.PropTypes will be deprecated in React v16
I use your react-modal-dialog in my application and I will be very grateful when you fix it in next release.
Could you change your repository?
It need three minutes to fix it.
Please add line:
var _propTypes = require('prop-types');
and on the end of your file change proptypes
CloseCircle.propTypes = {
diameter: _propTypes.number.isRequired
};
Please change it in every file where you using old React.PropTypas.
I will be very grateful when my application will start working again, because now this warning stops rendering content.
I am waiting for next version of react-modal-dialog.
Thanks in advance!