GH-2222: Expand dispatcher recovery + add periodic loop#2227
Closed
alekspetrov wants to merge 1 commit intomainfrom
Closed
GH-2222: Expand dispatcher recovery + add periodic loop#2227alekspetrov wants to merge 1 commit intomainfrom
alekspetrov wants to merge 1 commit intomainfrom
Conversation
…ecutor/`) - Add StaleRunningThreshold, StaleQueuedThreshold, StaleRecoveryInterval to DispatcherConfig (StaleTaskDuration kept as backwards-compat alias) - Rewrite recoverStaleTasks() to recover both running and queued orphans, marking them failed (not re-queued — re-queuing without a worker just recreates the orphan) - Change Start() to accept context.Context and launch runStaleRecoveryLoop goroutine that ticks every StaleRecoveryInterval - Add summary log "stale recovery complete, reset N tasks" on every pass (even when 0) for diagnosability - Update all Start() callers in main.go and tests - Add tests: TestRecoverStaleTasks_QueuedAndRunning, TestRecoverStaleTasks_RespectsThresholds, TestRunStaleRecoveryLoop_Periodic, TestQueueTask_AfterRecovery
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated PR created by Pilot for task GH-2222.
Closes #2222
Supersedes #2225
Changes
StaleRunningThreshold,StaleQueuedThreshold,StaleRecoveryIntervaltoDispatcherConfig(StaleTaskDurationkept as backwards-compat alias)recoverStaleTasks()to recover both running and queued orphans, marking them failed (not re-queued — re-queuing without a worker recreates the orphan)Start()to acceptcontext.Contextand launchrunStaleRecoveryLoopgoroutine that ticks everyStaleRecoveryInterval"stale recovery complete, reset N tasks"on every pass (even when 0) for diagnosabilityStart()callers inmain.goand testsTestRecoverStaleTasks_QueuedAndRunning,TestRecoverStaleTasks_RespectsThresholds,TestRunStaleRecoveryLoop_Periodic,TestQueueTask_AfterRecoveryTest plan
go build ./...passesgo test ./internal/executor/...— all new and existing tests passgo test ./...— full suite passes