fix(#1401): add validation to prevent invalid sample metadata registr…#1402
Draft
KochTobi wants to merge 1 commit intodevelopmentfrom
Draft
fix(#1401): add validation to prevent invalid sample metadata registr…#1402KochTobi wants to merge 1 commit intodevelopmentfrom
KochTobi wants to merge 1 commit intodevelopmentfrom
Conversation
…ation Users could register invalid sample metadata by clicking confirm despite validation errors being displayed. This fix adds validation checks in EditSampleBatchDialog.onConfirmClicked() to ensure sample metadata was successfully uploaded and validated before allowing registration. Changes: - Make uploadWithDisplay an instance field (was local variable) to allow state checking in onConfirmClicked() - Add validation logic to reject registration when: * No file was uploaded AND no validated metadata exists * File was uploaded BUT no validated metadata exists (validation failed) - Add test helper methods for improved testability: * getValidatedSampleMetadata() * getUploadWithDisplay() * setValidatedSampleMetadataForTest() Testing: - Added comprehensive unit tests (EditSampleBatchDialogSpec.groovy) - 14 test cases covering all validation paths and edge cases - Complete test plan with 7 manual integration test cases - 16-item regression testing checklist Documentation: - HANDOVER_ISSUE_1401.md: Comprehensive technical analysis - TEST_PLAN_ISSUE_1401.md: Testing procedures and checklist - IMPLEMENTATION_SUMMARY_ISSUE_1401.md: Change summary - IMPLEMENTATION_STATUS.md: Project status and verification Impact: - No breaking changes to API contracts - Fully backward compatible with event listeners - Data integrity is now protected from invalid metadata registration Fixes: #1401
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ation
Users could register invalid sample metadata by clicking confirm despite validation errors being displayed. This fix adds validation checks in EditSampleBatchDialog.onConfirmClicked() to ensure sample metadata was successfully uploaded and validated before allowing registration.
Changes:
Testing:
Documentation:
Impact:
Fixes: #1401