Implement EOS processing for GPIB interface#599
Merged
Conversation
Add code in GPIBsession _get_attribute and _set_attribute to map the TERMCHAR and TERMCHAR_EN attributes into the proper GPIB configuration settings. This allows GPIB reads to work correctly, when directed at older GPIB devices which do not signal EOI at the end of their talk output, but depend on EOS character matching.
for more information, see https://pre-commit.ci
MatthieuDartiailh
approved these changes
Jun 25, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
==========================================
- Coverage 39.29% 39.18% -0.11%
==========================================
Files 27 27
Lines 5008 5022 +14
Branches 513 518 +5
==========================================
Hits 1968 1968
- Misses 3014 3028 +14
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Please address the changelog conflicts and I will merge. |
Closed
Contributor
Author
|
I've modified the USBTMC PR to have the same (final) CHANGES text as this one. |
Contributor
Author
|
OK, I resolved it here in the PR, and I think it's good. |
DavidCPlatt
commented
Jun 26, 2026
DavidCPlatt
left a comment
DavidCPlatt
left a comment
Contributor
Author
There was a problem hiding this comment.
This looks fine - splitting the commentary along the lines of the two (albeit related) PRs makes sense. I'll remember this policy if it's relevant to any further changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add code in GPIBsession _get_attribute and _set_attribute to map the TERMCHAR and TERMCHAR_EN attributes into the proper GPIB configuration settings.
This allows GPIB reads to work correctly, when directed at older GPIB devices which do not signal EOI at the end of their talk output, but depend on EOS character matching.
black . && isort -c . && flake8with no errors