Skip to content

Conversation

HuanzhiMao
Copy link

@HuanzhiMao HuanzhiMao commented Aug 6, 2025

Context

What is the purpose of this PR? Is it to

  • fix a bug

Please link to any issues this PR addresses.

Changelog

What are the changes made in this PR?

  • Per the documentation, when using openai format dataset, the tool execution response should be added under the ipython role. But currently, it would give the following error ValueError: Tool or ipython message at index xx must follow an ipython message. This PR fixed this issue by introducing a minor update to the message processing logic in torchtune/data/_messages.py. The change ensures that the ipython field is properly included in the message object if present, defaulting to False otherwise.

Copy link

pytorch-bot bot commented Aug 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2906

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link

meta-cla bot commented Aug 6, 2025

Hi @HuanzhiMao!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

meta-cla bot commented Aug 6, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 6, 2025
@krammnic
Copy link
Collaborator

Hey! We actually plan to remove ipython attribute completely. cc @joecummings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants