Set expandable_segments explicitly via cuda memory API #2881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
expandable_segments
toTrue
for the CUDA allocator, making it more robust to the order in which torch and torchtune are imported.expandable_segments:False
to thePYTORCH_CUDA_ALLOC_CONF
environment variable.tests/__init__.py
but it's unclear to me if this is necessary anymore. I can re-add this if tests are failing due to memory issues.Note that if torchtune adds e.g. weight syncing via CUDA IPC it will be necessary to add a decorator that turns this off and on again since IPC for expandable segment tensors is not yet implemented in torch IIUC.
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example