Add fine-grained checkpoint saving controls #2854
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
This PR introduces two new features to control checkpoint saving behavior in the LoRA recipe:
epochs_to_save: A new argument that allows users to specify exactly which epochs to save. It can be set to 'all', 'none', or a comma-separated list of epoch numbers (e.g., '1,5,10').
save_last_epoch_only: This existing flag is now an override. If set to True, it will save only the final epoch, regardless of the epochs_to_save setting.
These features give users more control over disk space usage by allowing them to save only the checkpoints they need.
Changelog
What are the changes made in this PR?
Feature Implementation:
epochs_to_save
to the LoRA fine-tuning recipe, allowing users to save all, none, or a specific list of epoch checkpoints (e.g., '1,5,10').save_last_epoch_only
to act as an override, saving only the final epoch checkpoint regardless of other settings.Test Coverage:
test_save_last_epoch_only
integration test for regular checkpointing modetest_save_last_epoch_only_with_async_checkpointing
integration test for async checkpointing modeTest plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example