Skip to content

Conversation

DonggyuBan
Copy link

@DonggyuBan DonggyuBan commented Jun 27, 2025

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

This PR introduces two new features to control checkpoint saving behavior in the LoRA recipe:

  • epochs_to_save: A new argument that allows users to specify exactly which epochs to save. It can be set to 'all', 'none', or a comma-separated list of epoch numbers (e.g., '1,5,10').

  • save_last_epoch_only: This existing flag is now an override. If set to True, it will save only the final epoch, regardless of the epochs_to_save setting.

These features give users more control over disk space usage by allowing them to save only the checkpoints they need.

Changelog

What are the changes made in this PR?

Feature Implementation:

  • Introduced epochs_to_save to the LoRA fine-tuning recipe, allowing users to save all, none, or a specific list of epoch checkpoints (e.g., '1,5,10').
  • Enhanced save_last_epoch_only to act as an override, saving only the final epoch checkpoint regardless of other settings.
  • Ensured both features are compatible with regular and asynchronous checkpointing modes.

Test Coverage:

  • Added test_save_last_epoch_only integration test for regular checkpointing mode
  • Added test_save_last_epoch_only_with_async_checkpointing integration test for async checkpointing mode
  • Tests verify correct epoch folder creation behavior when feature is enabled/disabled

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

UX

If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example

  • I did not change any public API
  • I have added an example to docs or docstrings

Copy link

pytorch-bot bot commented Jun 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/2854

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @DonggyuBan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 18, 2025
Copy link

meta-cla bot commented Jul 18, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@DonggyuBan DonggyuBan changed the title Save last epoch only Add fine-grained checkpoint saving controls Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants