Skip to content

[DO NOT REVIEW] debug fsdp2 checkpoint for uneven sharding #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[DO NOT REVIEW] debug fsdp2 checkpoint for uneven sharding #1635

wants to merge 5 commits into from
+171 −16

Conversation

weifengpy
Copy link
Contributor

@weifengpy weifengpy commented Aug 25, 2025 •
edited
Loading

trying to resolve #1136

rm -rf outputs/checkpoint && NGPU=4 CONFIG_FILE="./torchtitan/models/llama3/train_configs/debug_model.toml" ./run_train.sh

@weifengpy
debug fsdp uunven sharding load checkpoint
76a73c4 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@weifengpy
add repro command
5b665f5 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@weifengpy
same model ref_model
b71efeb 
Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 25, 2025
@weifengpy weifengpy marked this pull request as draft August 25, 2025 21:38
@weifengpy
repro numeric diffrences before/after dcp load
728d3e2 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@weifengpy
repro at checkpoint
5429c43 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianyu-l tianyu-l Awaiting requested review from tianyu-l tianyu-l is a code owner

@fegin fegin Awaiting requested review from fegin fegin is a code owner

@wwwjn wwwjn Awaiting requested review from wwwjn wwwjn is a code owner

@wconstab wconstab Awaiting requested review from wconstab wconstab is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent loss when resume training with vocab size that is not divisible by world size.
1 participant
@weifengpy