Skip to content

Conversation

meetv18
Copy link

@meetv18 meetv18 commented Apr 23, 2025

Differential Revision: D73514829

Differential Revision: D73514829
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 23, 2025
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D73514829

Copy link
Contributor

@fegin fegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the unittest failing and linter failure are real. And it is not very safe to do FBCode first for torchtitan as we didn't see automatically landing when landing the diff internally first. This may cause the history out-of-sync.

@meetv18
Copy link
Author

meetv18 commented Apr 23, 2025

Cool, this is just a draft for now. I'll test with a few jobs as well after launching internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants