Skip to content

[lint] Download linters from pytorch/pytorch #6935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[lint] Download linters from pytorch/pytorch #6935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
74e4057
tc
clee2000 Jul 14, 2025
31bf5de
tc
clee2000 Jul 16, 2025
05fdc05
tc
clee2000 Jul 16, 2025
1349f4a
tc
clee2000 Jul 16, 2025
2ec5e00
tc
clee2000 Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/scripts/get_tutorials_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,14 @@
from subprocess import check_output
from typing import Any, Dict, List, NamedTuple, Optional, Union

import boto3 # type: ignore[import-not-found]
import boto3 # type: ignore[import-not-found,import-untyped]


METADATA_PATH = "ossci_tutorials_stats/metadata.csv"
FILENAMES_PATH = "ossci_tutorials_stats/filenames.csv"


def run_command(
cmd: str, cwd: Optional[str] = None, env=Optional[Dict[str, str]]
) -> str:
def run_command(cmd: str, cwd: Optional[str] = None, env=Optional[Dict[str, str]]):
"""
Run a shell command.

Expand Down
183 changes: 163 additions & 20 deletions .lintrunner.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,21 @@ exclude_patterns = [
]
command = [
'python3',
'tools/linter/adapters/flake8_linter.py',
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=flake8_linter.py',
'--',
'@{{PATHSFILE}}'
]
init_command = [
'python3',
'tools/linter/adapters/pip_init.py',
'tools/linter/adapters/run_from_link.py',
'--run-init',
'--init-name=pip_init.py',
'--init-link=https://raw.githubusercontent.com/pytorch/pytorch/b8895df8db23213a0db50fe833930dd1f4e4b5a5/tools/linter/adapters/pip_init.py',
'--lint-name=flake8_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/b8895df8db23213a0db50fe833930dd1f4e4b5a5/tools/linter/adapters/flake8_linter.py',
'--',
'--dry-run={{DRYRUN}}',
'flake8==6.1.0',
'flake8-bugbear==23.3.23',
Expand Down Expand Up @@ -55,14 +63,23 @@ exclude_patterns = [
]
command = [
'python3',
'tools/linter/adapters/mypy_linter.py',
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=mypy_linter.py',
'--',
'--config=mypy.ini',
'--',
'@{{PATHSFILE}}'
]
init_command = [
'python3',
'tools/linter/adapters/pip_init.py',
'tools/linter/adapters/run_from_link.py',
'--run-init',
'--init-name=pip_init.py',
'--init-link=https://raw.githubusercontent.com/pytorch/pytorch/b8895df8db23213a0db50fe833930dd1f4e4b5a5/tools/linter/adapters/pip_init.py',
'--lint-name=mypy_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/b8895df8db23213a0db50fe833930dd1f4e4b5a5/tools/linter/adapters/mypy_linter.py',
'--',
'--dry-run={{DRYRUN}}',
"boto3==1.38.29",
"botocore==1.38.29",
Expand Down Expand Up @@ -93,9 +110,20 @@ exclude_patterns = [
"tools/stronghold/src/api/types.py",
"tools/stronghold/tests/api/test_ast_param_types.py",
]
init_command = [
'python3',
'tools/linter/adapters/run_from_link.py',
'--lint-name=grep_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/267f82b860ccdf32df3dcb92e2435b64ba0f117a/tools/linter/adapters/grep_linter.py',
'--',
'--dry-run={{DRYRUN}}',
]
command = [
'python3',
'tools/linter/adapters/grep_linter.py',
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=grep_linter.py',
'--',
'--pattern=# type:\s*ignore([^\[]|$)',
'--linter-name=TYPEIGNORE',
'--error-name=unqualified type: ignore',
Expand All @@ -110,9 +138,20 @@ command = [
[[linter]]
code = 'NOQA'
include_patterns = ['**/*.py', '**/*.pyi']
init_command = [
'python3',
'tools/linter/adapters/run_from_link.py',
'--lint-name=grep_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/267f82b860ccdf32df3dcb92e2435b64ba0f117a/tools/linter/adapters/grep_linter.py',
'--',
'--dry-run={{DRYRUN}}',
]
command = [
'python3',
'tools/linter/adapters/grep_linter.py',
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=grep_linter.py',
'--',
'--pattern=# noqa([^:]|$)',
'--linter-name=NOQA',
'--error-name=unqualified noqa',
Expand All @@ -139,9 +178,19 @@ exclude_patterns=[
'.github/actions/upload-artifact-s3/dist/upload/index.js',
'tools/clang-tidy-checks/*-patches/**',
]
init_command = [
'python3',
'tools/linter/adapters/run_from_link.py',
'--lint-name=newlines_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/267f82b860ccdf32df3dcb92e2435b64ba0f117a/tools/linter/adapters/newlines_linter.py',
'--',
'--dry-run={{DRYRUN}}',
]
command = [
'python3',
'tools/linter/adapters/newlines_linter.py',
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=newlines_linter.py',
'--',
'@{{PATHSFILE}}',
]
Expand All @@ -159,9 +208,20 @@ exclude_patterns = [
'.github/actions/setup-ssh/index.js',
'.github/actions/upload-artifact-s3/dist/upload/index.js',
]
init_command = [
'python3',
'tools/linter/adapters/run_from_link.py',
'--lint-name=grep_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/267f82b860ccdf32df3dcb92e2435b64ba0f117a/tools/linter/adapters/grep_linter.py',
'--',
'--dry-run={{DRYRUN}}',
]
command = [
'python3',
'tools/linter/adapters/grep_linter.py',
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=grep_linter.py',
'--',
'--pattern=[[:blank:]]$',
'--linter-name=SPACES',
'--error-name=trailing spaces',
Expand Down Expand Up @@ -189,9 +249,20 @@ exclude_patterns = [
'terraform-aws-github-runner/**',
'aws/ami/windows/**',
]
init_command = [
'python3',
'tools/linter/adapters/run_from_link.py',
'--lint-name=grep_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/267f82b860ccdf32df3dcb92e2435b64ba0f117a/tools/linter/adapters/grep_linter.py',
'--',
'--dry-run={{DRYRUN}}',
]
command = [
'python3',
'tools/linter/adapters/grep_linter.py',
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=grep_linter.py',
'--',
# @lint-ignore TXT2
'--pattern= ',
'--linter-name=TABS',
Expand Down Expand Up @@ -222,9 +293,20 @@ exclude_patterns = [
".github/workflows/validate-linux-binaries.yml",
".github/workflows/validate-repackaged-binary-sizes.yml",
]
init_command = [
'python3',
'tools/linter/adapters/run_from_link.py',
'--lint-name=grep_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/267f82b860ccdf32df3dcb92e2435b64ba0f117a/tools/linter/adapters/grep_linter.py',
'--',
'--dry-run={{DRYRUN}}',
]
command = [
'python3',
'tools/linter/adapters/grep_linter.py',
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=grep_linter.py',
'--',
"""--pattern=\
(pip|pip3|python -m pip|python3 -m pip|python3 -mpip|python -mpip) \
install ([a-zA-Z0-9][A-Za-z0-9\\._\\-]+)([^/=<>~!]+)[A-Za-z0-9\\._\\-\\*\\+\\!]*$\
Expand Down Expand Up @@ -257,9 +339,19 @@ exclude_patterns = [
# Putting this exclusion just to get the linter running.
"tools/stronghold/bin/build-check-api-compatibility",
]
init_command = [
'python3',
'tools/linter/adapters/run_from_link.py',
'--lint-name=exec_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/267f82b860ccdf32df3dcb92e2435b64ba0f117a/tools/linter/adapters/exec_linter.py',
'--',
'--dry-run={{DRYRUN}}',
]
command = [
'python3',
'tools/linter/adapters/exec_linter.py',
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=exec_linter.py',
'--',
'@{{PATHSFILE}}',
]
Expand All @@ -275,14 +367,23 @@ include_patterns = [
]
command = [
'python3',
'tools/linter/adapters/actionlint_linter.py',
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=actionlint_linter.py',
'--',
'--binary=.lintbin/actionlint',
'--',
'@{{PATHSFILE}}',
]
init_command = [
'python3',
'tools/linter/adapters/s3_init.py',
'tools/linter/adapters/run_from_link.py',
'--run-init',
'--init-name=s3_init.py',
'--init-link=https://raw.githubusercontent.com/pytorch/pytorch/b8b840be3d03cf2f7dc4a373f9b0a95f1411cb89/tools/linter/adapters/s3_init.py',
'--lint-name=actionlint_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/267f82b860ccdf32df3dcb92e2435b64ba0f117a/tools/linter/adapters/actionlint_linter.py',
'--',
'--config-json=tools/linter/adapters/s3_init_config.json',
'--linter=actionlint',
'--dry-run={{DRYRUN}}',
Expand All @@ -298,13 +399,21 @@ include_patterns = [
]
command = [
'python3',
'tools/linter/adapters/pyfmt_linter.py',
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=pyfmt_linter.py',
'--',
'@{{PATHSFILE}}'
]
init_command = [
'python3',
'tools/linter/adapters/pip_init.py',
'tools/linter/adapters/run_from_link.py',
'--run-init',
'--init-name=pip_init.py',
'--init-link=https://raw.githubusercontent.com/pytorch/pytorch/b8895df8db23213a0db50fe833930dd1f4e4b5a5/tools/linter/adapters/pip_init.py',
'--lint-name=pyfmt_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/267f82b860ccdf32df3dcb92e2435b64ba0f117a/tools/linter/adapters/pyfmt_linter.py',
'--',
'--dry-run={{DRYRUN}}',
'--no-black-binary',
'black==23.12.1',
Expand All @@ -318,9 +427,20 @@ is_formatter = true
code = 'COPYRIGHT'
include_patterns = ['**']
exclude_patterns = ['.lintrunner.toml', '**/fixtures/**']
init_command = [
'python3',
'tools/linter/adapters/run_from_link.py',
'--lint-name=grep_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/267f82b860ccdf32df3dcb92e2435b64ba0f117a/tools/linter/adapters/grep_linter.py',
'--',
'--dry-run={{DRYRUN}}',
]
command = [
'python3',
'tools/linter/adapters/grep_linter.py',
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=grep_linter.py',
'--',
'--pattern=Confidential and proprietary',
'--linter-name=COPYRIGHT',
'--error-name=Confidential Code',
Expand All @@ -335,9 +455,19 @@ command = [
[[linter]]
code = 'LINTRUNNER_VERSION'
include_patterns = ['**']
init_command = [
'python3',
'tools/linter/adapters/run_from_link.py',
'--lint-name=lintrunner_version_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/267f82b860ccdf32df3dcb92e2435b64ba0f117a/tools/linter/adapters/lintrunner_version_linter.py',
'--',
'--dry-run={{DRYRUN}}',
]
command = [
'python3',
'tools/linter/adapters/lintrunner_version_linter.py'
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=lintrunner_version_linter.py',
]

[[linter]]
Expand All @@ -353,15 +483,24 @@ exclude_patterns = [
]
command = [
'python3',
'tools/linter/adapters/ruff_linter.py',
'tools/linter/adapters/run_from_link.py',
'--run-lint',
'--lint-name=ruff_linter.py',
'--',
'--config=pyproject.toml',
'--show-disable',
'--',
'@{{PATHSFILE}}'
]
init_command = [
'python3',
'tools/linter/adapters/pip_init.py',
'tools/linter/adapters/run_from_link.py',
'--run-init',
'--init-name=pip_init.py',
'--init-link=https://raw.githubusercontent.com/pytorch/pytorch/b8895df8db23213a0db50fe833930dd1f4e4b5a5/tools/linter/adapters/pip_init.py',
'--lint-name=ruff_linter.py',
'--lint-link=https://raw.githubusercontent.com/pytorch/pytorch/d0b98746039990d9f82f2c72d7256f89ac69875a/tools/linter/adapters/ruff_linter.py',
'--',
'--dry-run={{DRYRUN}}',
'ruff==0.8.4', # sync with PYFMT
]
Expand All @@ -377,7 +516,11 @@ command = [
]
init_command = [
'python3',
'tools/linter/adapters/pip_init.py',
'tools/linter/adapters/run_from_link.py',
'--run-init',
'--init-name=pip_init.py',
'--init-link=https://raw.githubusercontent.com/pytorch/pytorch/b8895df8db23213a0db50fe833930dd1f4e4b5a5/tools/linter/adapters/pip_init.py',
'--',
'--dry-run={{DRYRUN}}',
'sqlfluff==3.3.0',
]
Expand Down
Loading