runners: Add terraform module for scale-cycle #6893
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| { | ||
| "Version": "2012-10-17", | ||
| "Statement": [ | ||
| { | ||
| "Effect": "Allow", | ||
| "Action": [ | ||
| "ec2:DescribeInstances", | ||
| "ec2:DescribeTags", | ||
| "ec2:RunInstances", | ||
| "ec2:CreateNetworkInterface", | ||
| "ec2:DescribeNetworkInterfaces", | ||
| "ec2:DeleteNetworkInterface", | ||
| "ec2:DescribeImages", | ||
| "ec2:CreateTags", | ||
| "ec2:DeleteTags", | ||
| "ec2:CreateReplaceRootVolumeTask", | ||
| "ec2:DescribeReplaceRootVolumeTasks" | ||
|
There was a problem hiding this comment. What is this permission needed for? Scale up/down don't use it |
||
| ], | ||
| "Resource": ["*"] | ||
| }, | ||
| { | ||
| "Effect": "Allow", | ||
| "Action": [ | ||
| "ec2:CreateTags" | ||
| ], | ||
| "Resource": ["*"], | ||
| "Condition": { | ||
| "StringEquals": { | ||
| "ec2:CreateAction" : "RunInstances" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "Effect": "Allow", | ||
| "Action": "iam:PassRole", | ||
| "Resource": "${arn_runner_instance_role}" | ||
| }, | ||
| { | ||
| "Effect": "Allow", | ||
| "Action": ["ssm:PutParameter", "ssm:GetParameter", "ssm:DeleteParameter"], | ||
| "Resource": "*" | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,176 @@ | ||
| resource "aws_kms_grant" "scale_cycle" { | ||
| count = var.encryption.encrypt ? (var.enable_scale_cycle ? 1 : 0) : 0 | ||
| name = "${var.environment}-scale-cycle" | ||
| key_id = var.encryption.kms_key_id | ||
| grantee_principal = aws_iam_role.scale_cycle[0].arn | ||
| operations = ["Decrypt"] | ||
|
|
||
| constraints { | ||
| encryption_context_equals = { | ||
| Environment = var.environment | ||
| } | ||
| } | ||
| } | ||
|
|
||
| resource "aws_lambda_function" "scale_cycle" { | ||
| count = var.enable_scale_cycle ? 1 : 0 | ||
| s3_bucket = var.lambda_s3_bucket != null ? var.lambda_s3_bucket : null | ||
| s3_key = var.runners_lambda_s3_key != null ? var.runners_lambda_s3_key : null | ||
| s3_object_version = var.runners_lambda_s3_object_version != null ? var.runners_lambda_s3_object_version : null | ||
| filename = var.lambda_s3_bucket == null ? local.lambda_zip : null | ||
| source_code_hash = var.lambda_s3_bucket == null ? filebase64sha256(local.lambda_zip) : null | ||
| function_name = "${var.environment}-scale-cycle" | ||
| role = aws_iam_role.scale_cycle[0].arn | ||
| handler = "index.scaleCycle" | ||
| runtime = "nodejs20.x" | ||
| timeout = var.lambda_timeout_scale_cycle | ||
| tags = local.tags | ||
| memory_size = 2048 | ||
|
|
||
| environment { | ||
| variables = { | ||
| DATETIME_DEPLOY = local.datetime_deploy | ||
| ENABLE_ORGANIZATION_RUNNERS = var.enable_organization_runners | ||
| ENVIRONMENT = var.environment | ||
| GITHUB_APP_CLIENT_ID = var.github_app.client_id | ||
| GITHUB_APP_CLIENT_SECRET = var.github_app_client_secret | ||
| GITHUB_APP_ID = var.github_app.id | ||
| GITHUB_APP_KEY_BASE64 = var.github_app_key_base64 | ||
| KMS_KEY_ID = var.encryption.kms_key_id | ||
| LAMBDA_TIMEOUT = var.lambda_timeout_scale_cycle | ||
| LAUNCH_TEMPLATE_NAME_LINUX = var.launch_template_name_linux | ||
| LAUNCH_TEMPLATE_NAME_LINUX_ARM64 = var.launch_template_name_linux_arm64 | ||
| LAUNCH_TEMPLATE_NAME_LINUX_NVIDIA = var.launch_template_name_linux_nvidia | ||
| LAUNCH_TEMPLATE_NAME_WINDOWS = var.launch_template_name_windows | ||
| LAUNCH_TEMPLATE_VERSION_LINUX = var.launch_template_version_linux | ||
| LAUNCH_TEMPLATE_VERSION_LINUX_ARM64 = var.launch_template_version_linux_arm64 | ||
| LAUNCH_TEMPLATE_VERSION_LINUX_NVIDIA = var.launch_template_version_linux_nvidia | ||
| LAUNCH_TEMPLATE_VERSION_WINDOWS = var.launch_template_version_windows | ||
| MINIMUM_RUNNING_TIME_IN_MINUTES = var.minimum_running_time_in_minutes | ||
| REDIS_ENDPOINT = var.redis_endpoint | ||
| REDIS_LOGIN = var.redis_login | ||
| RUNNER_EXTRA_LABELS = var.runner_extra_labels | ||
| SCALE_CONFIG_ORG = var.scale_config_org | ||
| SCALE_CONFIG_REPO = var.scale_config_repo | ||
| SCALE_CONFIG_REPO_PATH = var.scale_config_repo_path | ||
| SECRETSMANAGER_SECRETS_ID = var.secretsmanager_secrets_id | ||
|
|
||
| AWS_REGIONS_TO_VPC_IDS = join( | ||
| ",", | ||
| sort(distinct([ | ||
| for region_vpc in var.vpc_ids : | ||
| format("%s|%s", region_vpc.region, region_vpc.vpc) | ||
| ])) | ||
| ) | ||
| VPC_ID_TO_SECURITY_GROUP_IDS = join( | ||
| ",", | ||
| sort(distinct(concat( | ||
| [ | ||
| for vpc in var.vpc_ids : | ||
| format( | ||
| "%s|%s", | ||
| vpc.vpc, | ||
| var.runners_security_group_ids[local.vpc_id_to_idx[vpc.vpc]] | ||
| ) | ||
| ], | ||
| [ | ||
| for vpc_subnet in var.vpc_sgs : | ||
| format("%s|%s", vpc_subnet.vpc, vpc_subnet.sg) | ||
| ] | ||
| ))) | ||
| ) | ||
| VPC_ID_TO_SUBNET_IDS = join( | ||
| ",", | ||
| sort(distinct([ | ||
| for vpc_subnet in var.subnet_vpc_ids : | ||
| format("%s|%s", vpc_subnet.vpc, vpc_subnet.subnet) | ||
| ])) | ||
| ) | ||
| SUBNET_ID_TO_AZ = join( | ||
| ",", | ||
| sort(distinct([ | ||
| for subnet_az in var.subnet_azs : | ||
| format("%s|%s", subnet_az.subnet, subnet_az.az) | ||
| ])) | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| vpc_config { | ||
| security_group_ids = concat( | ||
| var.lambda_security_group_ids, | ||
| [var.runners_security_group_ids[0]] | ||
| ) | ||
| subnet_ids = var.lambda_subnet_ids | ||
| } | ||
| } | ||
|
|
||
| resource "aws_cloudwatch_log_group" "scale_cycle" { | ||
| count = var.enable_scale_cycle ? 1 : 0 | ||
| name = "/aws/lambda/${aws_lambda_function.scale_cycle[0].function_name}" | ||
| retention_in_days = var.logging_retention_in_days | ||
| tags = var.tags | ||
| } | ||
|
|
||
| resource "aws_cloudwatch_event_rule" "scale_cycle" { | ||
| count = var.enable_scale_cycle ? 1 : 0 | ||
| name = "${var.environment}-scale-cycle-rule" | ||
| schedule_expression = var.scale_cycle_schedule_expression | ||
| tags = var.tags | ||
| } | ||
|
|
||
| resource "aws_cloudwatch_event_target" "scale_cycle" { | ||
| count = var.enable_scale_cycle ? 1 : 0 | ||
| rule = aws_cloudwatch_event_rule.scale_cycle[0].name | ||
| arn = aws_lambda_function.scale_cycle[0].arn | ||
| } | ||
|
|
||
| resource "aws_lambda_permission" "scale_cycle" { | ||
| count = var.enable_scale_cycle ? 1 : 0 | ||
| statement_id = "AllowExecutionFromCloudWatch" | ||
| action = "lambda:InvokeFunction" | ||
| function_name = aws_lambda_function.scale_cycle[0].function_name | ||
| principal = "events.amazonaws.com" | ||
| source_arn = aws_cloudwatch_event_rule.scale_cycle[0].arn | ||
| } | ||
|
|
||
| resource "aws_iam_role" "scale_cycle" { | ||
| count = var.enable_scale_cycle ? 1 : 0 | ||
| name = "${var.environment}-action-scale-cycle-lambda-role" | ||
| assume_role_policy = data.aws_iam_policy_document.lambda_assume_role_policy.json | ||
| path = local.role_path | ||
| permissions_boundary = var.role_permissions_boundary | ||
| tags = local.tags | ||
| } | ||
|
|
||
| resource "aws_iam_role_policy" "scale_cycle" { | ||
| count = var.enable_scale_cycle ? 1 : 0 | ||
| name = "${var.environment}-lambda-scale-cycle-policy" | ||
| role = aws_iam_role.scale_cycle[0].name | ||
| policy = templatefile("${path.module}/policies/lambda-scale-cycle.json", { | ||
| arn_runner_instance_role = var.role_runner_arn | ||
| }) | ||
| } | ||
|
|
||
| resource "aws_iam_role_policy" "scale_cycle_logging" { | ||
| count = var.enable_scale_cycle ? 1 : 0 | ||
| name = "${var.environment}-lambda-logging" | ||
| role = aws_iam_role.scale_cycle[0].name | ||
| policy = templatefile("${path.module}/policies/lambda-cloudwatch.json", { | ||
| log_group_arn = aws_cloudwatch_log_group.scale_cycle[0].arn | ||
| }) | ||
| } | ||
|
|
||
| resource "aws_iam_role_policy_attachment" "scale_cycle_vpc_execution_role" { | ||
| count = length(var.lambda_subnet_ids) > 0 ? (var.enable_scale_cycle ? 1 : 0) : 0 | ||
| role = aws_iam_role.scale_cycle[0].name | ||
| policy_arn = "arn:aws:iam::aws:policy/service-role/AWSLambdaVPCAccessExecutionRole" | ||
| } | ||
|
|
||
| resource "aws_iam_role_policy" "scale_cycle_secretsmanager_access" { | ||
| count = var.secretsmanager_secrets_id != null ? (var.enable_scale_cycle ? 1 : 0) : 0 | ||
| role = aws_iam_role.scale_cycle[0].name | ||
| policy = templatefile("${path.module}/policies/lambda-secretsmanager.json", { | ||
| secretsmanager_arn = data.aws_secretsmanager_secret_version.app_creds.arn | ||
| }) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these actually needed? I do see that scale up has these as well, but it seems odd that they'd require this permission.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is techincally what is needed to create an EC2 instance
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is only necessary if we need more complex networking outside of what EC2 instance launch creates when you create a new EC2 instance. Like an instance with multiple NICs connected to more than 1 network.
Edit: I think
ec2:RunInstancealready creates the default NIC.