Skip to content

Catch exception from shm connection start() #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Catch exception from shm connection start() #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions tensorpipe/transport/shm/connection.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,15 @@ Connection::~Connection() {
void Connection::start() {
// Create ringbuffer for inbox.
std::shared_ptr<util::ringbuffer::RingBuffer> inboxRingBuffer;
std::tie(inboxHeaderFd_, inboxDataFd_, inboxRingBuffer) =
util::ringbuffer::shm::create(kDefaultSize);
try {
std::tie(inboxHeaderFd_, inboxDataFd_, inboxRingBuffer) =
util::ringbuffer::shm::create(kDefaultSize);
} catch (std::system_error& e) {
state_ = INITIALIZING_ERROR;
// Triggers destructor.
TP_THROW_SYSTEM(errno) << "Error while creating shm with " << kDefaultSize
<< " bytes";
}
inbox_.emplace(std::move(inboxRingBuffer));

// Register method to be called when our peer writes to our inbox.
Expand Down Expand Up @@ -429,6 +436,9 @@ void Connection::close() {
// can't extend its lifetime by capturing a shared_ptr and increasing its
// refcount.
std::unique_lock<std::mutex> guard(mutex_);
if (state_ == INITIALIZING_ERROR) {
return;
}
closeHoldingMutex();
}

Expand Down
1 change: 1 addition & 0 deletions tensorpipe/transport/shm/connection.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class Connection final : public transport::Connection,

enum State {
INITIALIZING = 1,
INITIALIZING_ERROR,
SEND_FDS,
RECV_FDS,
ESTABLISHED,
Expand Down