[Feature] Add more supports for NPU in addition to CUDA in previously supported use cases. #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
vmoens
reviewed
Oct 25, 2025
Collaborator
vmoens
left a comment
vmoens
left a comment
There was a problem hiding this comment.
Thanks for this PR! Some comments but generally ok with it
vmoens
reviewed
Oct 25, 2025
Collaborator
vmoens
left a comment
vmoens
left a comment
There was a problem hiding this comment.
Thanks for this PR! Some comments but generally ok with it
Contributor
Author
|
@vmoens Could you please approve the workflow and this pull request? |
Contributor
Author
|
Do you have any problems with this PR? May it be merged? @vmoens |
vmoens
approved these changes
Nov 12, 2025
Collaborator
|
Let's wait a bit for the tests to pass and I'll merge! Thanks for contributing |
Contributor
Author
|
Some tests failed but I think they are related to Win platform or some env problems? @vmoens |
vmoens
changed the title
Collaborator
|
sorry I was away last week, trying to fix a couple of things then we'll be good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more supports for NPU in addition to CUDA in previously supported use cases.
Description
Add more supports for NPU in addition to CUDA in previously supported use cases.
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!