Skip to content

[generate_ast] providing AST args, and fall back to api._codegen when output is a tuple #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 13, 2025

Conversation

HanGuo97
Copy link
Contributor

This PR addresses two main points:

  1. Piping AST arguments into ._codegen
  2. When the host-side function returns a sequence-like output but is not TileIndexType, correctly fallback to using api._codegen

Side note, I’m not entirely sure how to handle default AST arguments. For now, I’m just using ast_params.apply_defaults(), but I’m unsure if that’s the best way.

Copy link

meta-cla bot commented Aug 10, 2025

Hi @HanGuo97!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 10, 2025
jansel
jansel previously approved these changes Aug 11, 2025
@jansel
Copy link
Contributor

jansel commented Aug 11, 2025

Can you fix the lints?

@HanGuo97
Copy link
Contributor Author

done!

@jansel jansel closed this Aug 13, 2025
@jansel jansel reopened this Aug 13, 2025
@pytorch-bot pytorch-bot bot dismissed jansel’s stale review August 13, 2025 15:30

This PR was reopened (likely due to being reverted), so your approval was removed. Please request another review.

@jansel jansel merged commit 01c831e into pytorch:main Aug 13, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants