Fix unused-local-typedef issue #13267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-barnes
requested review from
JacobSzwejbka,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13267
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 Unrelated FailuresAs of commit e15fc14 with merge base ea4a7fa ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79834770 |
|
@pytorchbot label "release notes: cpp" |
|
Didn't find following labels among repository labels: release notes: cpp |
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
|
@pytorchbot label "topic: not user facing" |
swolchok
approved these changes
Aug 13, 2025
Summary: LLVM has a warning `-Wunused-local-typedef` which we are enabling to remove unused code. This has the side-effect of making it easier to do refactors should as removing unnecessary includes. For questions/comments, contact r-barnes. - If you approve of this diff, please use the "Accept & Ship" button :-) Reviewed By: swolchok Differential Revision: D79834770
r-barnes
force-pushed
the
export-D79834770
branch
from
973c946 to
e15fc14
Compare
r-barnes
changed the title
|
This pull request was exported from Phabricator. Differential Revision: D79834770 |
agrima1304
pushed a commit
to agrima1304/executorch
that referenced
this pull request
Aug 26, 2025
Differential Revision: D79834770 Pull Request resolved: pytorch#13267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
LLVM has a warning
-Wunused-local-typedefwhich we are enabling to remove unused code. This has the side-effect of making it easier to do refactors should as removing unnecessary includes.For questions/comments, contact r-barnes.
Differential Revision: D79834770