Fix Samsung Exynos 2000 series chipset detection #309
Conversation
|
Hi @bc-lee! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
There was a problem hiding this comment.
Looks good. Testing on s908b
SoC name: Samsung Exynos 9925
Microarchitectures:
1x Cortex-X2
3x Cortex-A710
4x Cortex-A510
Cores:
0: 1 processor (0), ARM Cortex-X2
1: 1 processor (1), ARM Cortex-A710
2: 1 processor (2), ARM Cortex-A710
3: 1 processor (3), ARM Cortex-A710
4: 1 processor (4), ARM Cortex-A510
5: 1 processor (5), ARM Cortex-A510
6: 1 processor (6), ARM Cortex-A510
7: 1 processor (7), ARM Cortex-A510
|
Thanks for the review! Regarding the CLA, it's out of my hands, but I’ll ask my legal team to sign it as soon as possible. |
|
I signed the CLA! |
|
@digantdesai can you take a look? |
|
Not sure why I don't see a button to run the CI, can you please rebase/repush? |
Add support for "s5e" prefix pattern matching in `ro.product.board` property to correctly identify Samsung Exynos 2000 series chipsets. These chipsets use generic identifiers (e.g., `s5e9925`) instead of marketing names like "Exynos 2200", but can still be identified and mapped to their corresponding models using external resources. Implements `match_s5e()` function to parse the s5e<4-digit-model> format.
|
Since this is my first time contributing to this repository, I believe a maintainer needs to approve the GitHub Actions run. Screenshot: |
|
Ok now I see the button. Its running :) |
|
Can you please fix the CI? |
|
@digantdesai I’ve pushed the changes. As before, you or a maintainer will need to trigger the CI. |
Add support for "s5e" prefix pattern matching in
ro.product.boardproperty to correctly identify Samsung Exynos 2000 series chipsets. These chipsets use generic identifiers (e.g.,s5e9925) instead of marketing names like "Exynos 2200", but can still be identified and mapped to their corresponding models using external resources.Implements
match_s5e()function to parse the s5e<4-digit-model> format.Fixes #308