-
Notifications
You must be signed in to change notification settings - Fork 284
Add pt2e tutorials to torchao doc page #2384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2384
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 4 PendingAs of commit 15ab040 with merge base 5239ce7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
5787021
to
7743246
Compare
tutorials_source/pt2e_quant_x86_inductor | ||
tutorials_source/pt2e_quant_xpu_inductor | ||
tutorials_source/pt2e_quantizer | ||
tutorials_source/openvino_quantizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also what do you think about renaming these tutorials to make the titles look more consistent, e.g.
PyTorch 2 Export: Post-Training Quantization (PTQ) (prototype)
PyTorch 2 Export: Quantization-Aware Training (QAT) (prototype)
PyTorch 2 Export: Quantization with X86 Backend through Inductor
PyTorch 2 Export: Quantization with Intel GPU Backend through Inductor
PyTorch 2 Export: How to Write Your Own Quantizer
PyTorch 2 Export: Quantization for OpenVINO torch.compile Backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are all under a "PyTorch 2 Export Tutorials" section I feel we can even just drop the prefix in front of each one of these (but keep them on the actual tutorial page if that's possible, not sure how though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have put these in a separate category
# we have a model with aten ops doing integer computations when possible | ||
# move the quantized model to eval mode, equivalent to `m.eval()` | ||
torch.ao.quantization.move_exported_model_to_eval(converted_model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we also migrate this helper function over? I feel this is needed for QAT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we did
bcc9a54
to
853f501
Compare
cc @Xia-Weiwen @leslie-fang-intel we are moving these tutorials to torchao docs, please take a look I just moved the docs, haven't really checking whether these new APIs works or not since it may require updates in the backend quantizers. please help check the new APIs and also help update backend related code to make sure the tutorials works as well |
Hello, @jerryzh168! So the question is - when there will be the next executorch release? Will it depend on the latest torch==2.7.1? |
@daniil-lyakhov XNNPACKQuantizer is moved to executorch and X86InductorQuantizer is also moved to torchao can you change dependency to these? ET next release is end of July: pytorch/executorch#11075, torchao next release will happen soon.
I heard from @metascroy that it will depend on 2.8 I'm not sure how the dependency situation in nncf, but typically the way we are doing it is have some version check for the required libraries like Lines 363 to 369 in 63a91d7
for example currently torchao only supports pytorch version >= 2.5.1 it probably doesn't have to block the doc, I can put up the doc first and feel free to update the new torchao doc and remove the old one when you are ready |
Summary: att, after we migrate pt2e quant code from pytorch to torchao, now we also want to migrate the docs as well Test Plan: check generated docs Reviewers: Subscribers: Tasks: Tags:
Summary:
att, after we migrate pt2e quant code from pytorch to torchao, now we also want to migrate the docs as well
Test Plan:
check generated docs
Reviewers:
Subscribers:
Tasks:
Tags: