Skip to content

fixing trunk - autoquant test failure #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

fixing trunk - autoquant test failure #2363

merged 1 commit into from
Jun 12, 2025

Conversation

HDCharles
Copy link
Contributor

@HDCharles HDCharles commented Jun 12, 2025

Summary:

fix autoquant failure.

tests started failing recently in pytorch nightly: https://github.com/pytorch/ao/actions/runs/15590189942/job/43907010550

its unclear where this error is coming from for autoquant, i can't repro it locally

made an issue here: pytorch/pytorch#155838 the test can be re-enabled once this is resolved

Test Plan:

see CI

Reviewers:

Subscribers:

Tasks:

Tags:

Copy link

pytorch-bot bot commented Jun 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2363

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 11 Pending

As of commit 2e6d8bd with merge base b51b2ec (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 12, 2025
@HDCharles HDCharles added the topic: bug fix Use this tag for PRs that fix bugs label Jun 12, 2025
@HDCharles HDCharles force-pushed the 094_fix_trunk branch 4 times, most recently from ec925d4 to d67e925 Compare June 12, 2025 18:17
@HDCharles HDCharles changed the title fixing autoquant bug fixing trunk (autoquant, ruff) Jun 12, 2025
@HDCharles HDCharles force-pushed the 094_fix_trunk branch 4 times, most recently from a5e1d70 to eb4fe2a Compare June 12, 2025 20:49
Summary:

tests started failing recently in pytorch nightly: https://github.com/pytorch/ao/actions/runs/15590189942/job/43907010550

There was an old requirement for dynamic quant to have a minimum size
greater than 16 but then after some pytorch changes it was no longer
necessary, now its back

Test Plan: python test/integration/test_integration.py -k
"test_autoquant_compile"

also see CI since i can't repro this error locally hopefully this
resolves the CI error

Reviewers:

Subscribers:

Tasks:

Tags:

Update test_integration.py

more fixes

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@HDCharles HDCharles changed the title fixing trunk (autoquant, ruff) fixing trunk - autoquant test failure Jun 12, 2025
@HDCharles HDCharles merged commit dd22777 into main Jun 12, 2025
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: bug fix Use this tag for PRs that fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants