Skip to content

Inference tutorial - Part 3 of e2e series [WIP] #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

jainapurva
Copy link
Contributor

No description provided.

Copy link

pytorch-bot bot commented Jun 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2343

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6a96697 with merge base 5239ce7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2025
@jainapurva jainapurva added the topic: documentation Use this tag if this PR adds or improves documentation label Jun 10, 2025
+----------------------------+----------------+------------------------------+


Sparsity Integration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be a separate section I think, it can be merged into Float8 Dynamic Quantization section, and just mention for more quantization/sparsity, please see https://huggingface.co/docs/transformers/main/en/quantization/torchao

print("Response:", output_text[0][len(prompt):])
[Optional] Float8 Dynamic Quantization + Semi-structured (2:4) sparsity
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerryzh168 @jcaip Does this look good? Should I keep sparsity as a optional section or just mention it in note

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just add to huggingface torchao page?

Memory Benchmarking
--------------------

**Memory Usage Comparison**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove

vllm serve pytorch/Phi-4-mini-instruct-float8dq --tokenizer microsoft/Phi-4-mini-instruct -O3
Inference with vLLM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we move this after Inference with Transformers


vLLM automatically leverages torchao's optimized kernels when serving quantized models, providing significant throughput improvements.

Setting up vLLM with Quantized Models
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this doesn't have to be a new section I think

Performance Breakdown
=====================

When using vLLM with torchao:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not a comprehensive list, probably just remove, do we have a exhaustive list of all the techniques that we support?

@andrewor14
Copy link
Contributor

Hi @jainapurva, by the way I'm adding a serving.rst here: #2394. It uses the same template as parts 1 and 2. After that's landed, do you mind updating your PR to use that file instead? Right now it's a blank page with the template:

Screenshot 2025-06-17 at 5 48 14 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: documentation Use this tag if this PR adds or improves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants