Add tracking and streaming logic to SplitTableBatchedEmbeddingBagsCodegen #4741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D78438757 |
chouxi
force-pushed
the
export-D78438757
branch
from
44ad850 to
603cd3d
Compare
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 19, 2025
…egen (pytorch#4741) Summary: X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
chouxi
force-pushed
the
export-D78438757
branch
from
603cd3d to
7893c00
Compare
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 19, 2025
…egen (pytorch#4741) Summary: X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
|
This pull request was exported from Phabricator. Differential Revision: D78438757 |
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 19, 2025
…egen (pytorch#4741) Summary: Pull Request resolved: pytorch#4741 X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
chouxi
force-pushed
the
export-D78438757
branch
from
7893c00 to
5e66106
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78438757 |
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 20, 2025
…egen (pytorch#4741) Summary: Pull Request resolved: pytorch#4741 X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
chouxi
force-pushed
the
export-D78438757
branch
2 times, most recently
from
c24034b to
a84f568
Compare
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 20, 2025
…egen (pytorch#4741) Summary: X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 20, 2025
…egen (pytorch#4741) Summary: X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
chouxi
force-pushed
the
export-D78438757
branch
from
a84f568 to
8876f3e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78438757 |
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 20, 2025
…egen (pytorch#4741) Summary: Pull Request resolved: pytorch#4741 X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
chouxi
force-pushed
the
export-D78438757
branch
from
8876f3e to
40a5530
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78438757 |
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 20, 2025
…egen (pytorch#4741) Summary: Pull Request resolved: pytorch#4741 X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
chouxi
force-pushed
the
export-D78438757
branch
2 times, most recently
from
dbe6dcf to
b3ccd68
Compare
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 21, 2025
…egen (pytorch#4741) Summary: X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 21, 2025
…egen (pytorch#4741) Summary: X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
chouxi
force-pushed
the
export-D78438757
branch
from
b3ccd68 to
0c96333
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78438757 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D78438757 |
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 21, 2025
…egen (pytorch#4741) Summary: Pull Request resolved: pytorch#4741 X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
chouxi
force-pushed
the
export-D78438757
branch
from
0c96333 to
4b83779
Compare
Differential Revision: D79119246
chouxi
force-pushed
the
export-D78438757
branch
from
4b83779 to
db8b273
Compare
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 23, 2025
…egen (pytorch#4741) Summary: X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
|
This pull request was exported from Phabricator. Differential Revision: D78438757 |
chouxi
force-pushed
the
export-D78438757
branch
from
db8b273 to
04d0de8
Compare
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 25, 2025
…egen (pytorch#4741) Summary: X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
chouxi
force-pushed
the
export-D78438757
branch
from
04d0de8 to
12588c5
Compare
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 25, 2025
…egen (pytorch#4741) Summary: X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
|
This pull request was exported from Phabricator. Differential Revision: D78438757 |
chouxi
force-pushed
the
export-D78438757
branch
from
12588c5 to
57c7064
Compare
chouxi
added a commit
to chouxi/FBGEMM
that referenced
this pull request
Aug 25, 2025
…egen (pytorch#4741) Summary: Pull Request resolved: pytorch#4741 X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
…egen (pytorch#4741) Summary: Pull Request resolved: pytorch#4741 X-link: facebookresearch/FBGEMM#1762 It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3 It tries to 1. store the updated ids/count 2. next iteration streams out the updated embeddings and ids, before the embedding cache are populated again. the prefetch pipeline logic also the same to SSDTBE. Differential Revision: D78438757
|
This pull request was exported from Phabricator. Differential Revision: D78438757 |
chouxi
force-pushed
the
export-D78438757
branch
from
57c7064 to
62920df
Compare
|
This pull request has been merged in fee98b8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1762
It follows similar logic to SSD TBE https://fburl.com/code/fxdcxma3
It tries to
the prefetch pipeline logic also the same to SSDTBE.
Differential Revision: D78438757