-
Notifications
You must be signed in to change notification settings - Fork 28
Export GDPA kernel impl to OSS #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary: - Export GDPA kernel to OSS - Clean up some functionality and make sure the kernel only includes GDPA Differential Revision: D78926734
This pull request was exported from Phabricator. Differential Revision: D78926734 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution - can you please take a look at the linting error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check out the inline comments, thanks!
Example commands: | ||
``` | ||
# Run optimized GDPA with different sparsity levels for PFFN | ||
buck2 run @mode/opt //pytorch/tritonbench:run -- \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to the OSS command python run.py
?
@@ -0,0 +1,262 @@ | |||
# (c) Meta Platforms, Inc. and affiliates. Confidential and proprietary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need to remove this line after oss
Summary: - Export GDPA kernel to OSS - Clean up some functionality and make sure the kernel only includes GDPA Differential Revision: D78926734
Summary: - Export GDPA kernel to OSS - Clean up some functionality and make sure the kernel only includes GDPA Differential Revision: D78926734
Summary: - Export GDPA kernel to OSS - Clean up some functionality and make sure the kernel only includes GDPA Differential Revision: D78926734
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary:
Differential Revision: D78926734