Skip to content

Export GDPA kernel impl to OSS #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

jackiexu1992
Copy link
Contributor

Summary:

  • Export GDPA kernel to OSS
  • Clean up some functionality and make sure the kernel only includes GDPA

Differential Revision: D78926734

Summary:
- Export GDPA kernel to OSS
- Clean up some functionality and make sure the kernel only includes GDPA

Differential Revision: D78926734
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78926734

Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution - can you please take a look at the linting error?

Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check out the inline comments, thanks!

Example commands:
```
# Run optimized GDPA with different sparsity levels for PFFN
buck2 run @mode/opt //pytorch/tritonbench:run -- \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change this to the OSS command python run.py?

@@ -0,0 +1,262 @@
# (c) Meta Platforms, Inc. and affiliates. Confidential and proprietary.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to remove this line after oss

facebook-github-bot pushed a commit that referenced this pull request Jul 28, 2025
Summary:

- Export GDPA kernel to OSS
- Clean up some functionality and make sure the kernel only includes GDPA

Differential Revision: D78926734
facebook-github-bot pushed a commit that referenced this pull request Jul 28, 2025
Summary:

- Export GDPA kernel to OSS
- Clean up some functionality and make sure the kernel only includes GDPA

Differential Revision: D78926734
facebook-github-bot pushed a commit that referenced this pull request Jul 28, 2025
Summary:

- Export GDPA kernel to OSS
- Clean up some functionality and make sure the kernel only includes GDPA

Differential Revision: D78926734
FindHao pushed a commit that referenced this pull request Jul 28, 2025
Summary:
Pull Request resolved: #308

Pull Request resolved: #302

- Export GDPA kernel to OSS
- Clean up some functionality and make sure the kernel only includes GDPA

Differential Revision: D78926734
FindHao pushed a commit that referenced this pull request Jul 28, 2025
Summary:
Pull Request resolved: #308

Pull Request resolved: #302

- Export GDPA kernel to OSS
- Clean up some functionality and make sure the kernel only includes GDPA

Differential Revision: D78926734
Copy link
Member

@FindHao FindHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@FindHao FindHao merged commit 78d1d8b into pytorch-labs:main Jul 29, 2025
3 of 8 checks passed
FindHao added a commit that referenced this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants