Fix a few open source tests #616
Closed
+85
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78747980 |
allenwang28
force-pushed
the
export-D78747980
branch
from
8ed859b to
40803f7
Compare
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Jul 22, 2025
Summary: Changes: - For rust bindings, move RDMA manager creation into a classmethod - test_rdma is failing because `needs_rdma` typo Rollback Plan: Differential Revision: D78747980
|
This pull request was exported from Phabricator. Differential Revision: D78747980 |
allenwang28
force-pushed
the
export-D78747980
branch
from
40803f7 to
81d94ec
Compare
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Jul 23, 2025
Summary: Fixes: - test_python_actors - test_allocator - test_rdma Changes: - test_python_actors was failing due to rust bindings. This moves RDMA manager creation into a classmethod - test_allocator was failing due to an aggressive regex. Relaxed this. - test_rdma had a typo in `needs_rdma` - in test_mailbox.py, for whatever reason the cast was taking a really long time to complete. The logic is the same without the cast. This doesn't fix all of the tests Rollback Plan: Differential Revision: D78747980
|
This pull request was exported from Phabricator. Differential Revision: D78747980 |
allenwang28
force-pushed
the
export-D78747980
branch
from
81d94ec to
3e2df08
Compare
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Jul 23, 2025
Summary: Fixes: - test_python_actors - test_allocator - test_rdma Changes: - test_python_actors was failing due to rust bindings. This moves RDMA manager creation into a classmethod - test_allocator was failing due to an aggressive regex. Relaxed this. - test_rdma had a typo in `needs_rdma` - in test_mailbox.py, for whatever reason the cast was taking a really long time to complete. The logic is the same without the cast. This doesn't fix all of the tests. Remaining failures: - `python/tests/builtins/test_log.py` - `python/tests/builtins/test_random.py` - `python/tests/test_actor_error.py` - `python/tests/test_controller.py` Differential Revision: D78747980
|
This pull request was exported from Phabricator. Differential Revision: D78747980 |
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Jul 23, 2025
Summary: Changes: - test_python_actors was failing due to rust bindings. This moves RDMA manager creation into a classmethod - test_allocator was failing due to an aggressive regex. Relaxed this. - test_rdma had a typo in `needs_rdma` - in test_mailbox.py, for whatever reason the cast was taking a really long time to complete. The logic is the same without the cast. - fixes some logic in `HAS_TENSOR_ENGINE` for deciding on whether or not to start RDMA manager actor. - Disable `test_actor_mesh.py` tests. For some reason, after D78292490, this test stopped cleaning up properly which affects downstream tests when running sequentially. Specifically, `builtins/test_log.py` and `builtins/test_random.py`. Syncing with pzhan9, there's currently an issue where unclean shutdown can lead to fatal error that's being actively worked on. We should re-enable these tests once that is resolved. Differential Revision: D78747980
allenwang28
force-pushed
the
export-D78747980
branch
from
3e2df08 to
3bdf952
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78747980 |
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Jul 23, 2025
Summary: Changes: - test_python_actors was failing due to rust bindings. This moves RDMA manager creation into a classmethod - test_allocator was failing due to an aggressive regex. Relaxed this. - test_rdma had a typo in `needs_rdma` - in test_mailbox.py, for whatever reason the cast was taking a really long time to complete. The logic is the same without the cast. - fixes some logic in `HAS_TENSOR_ENGINE` for deciding on whether or not to start RDMA manager actor. - Disable `test_actor_mesh.py` tests. For some reason, after D78292490, this test stopped cleaning up properly which affects downstream tests when running sequentially. Specifically, `builtins/test_log.py` and `builtins/test_random.py`. Syncing with pzhan9, there's currently an issue where unclean shutdown can lead to fatal error that's being actively worked on. We should re-enable these tests once that is resolved. remaining failures: - test_actor_error::test_supervigion_with_sending_error - test_controller:: test_timeout_warning Differential Revision: D78747980
allenwang28
force-pushed
the
export-D78747980
branch
from
3bdf952 to
5506fc1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78747980 |
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Jul 23, 2025
Summary: Changes: - test_python_actors was failing due to rust bindings. This moves RDMA manager creation into a classmethod - test_allocator was failing due to an aggressive regex. Relaxed this. - test_rdma had a typo in `needs_rdma` - in test_mailbox.py, for whatever reason the cast was taking a really long time to complete. The logic is the same without the cast. - fixes some logic in `HAS_TENSOR_ENGINE` for deciding on whether or not to start RDMA manager actor. - Disable `test_actor_mesh.py` tests. For some reason, after D78292490, this test stopped cleaning up properly which affects downstream tests when running sequentially. Specifically, `builtins/test_log.py` and `builtins/test_random.py`. Syncing with pzhan9, there's currently an issue where unclean shutdown can lead to fatal error that's being actively worked on. We should re-enable these tests once that is resolved. remaining failures that are marked as skipped in OSS: - test_actor_error::test_supervision_with_sending_error - test_controller:: test_timeout_warning These tests seem to fail when run in isolation, but fail when run sequentially. Differential Revision: D78747980
allenwang28
force-pushed
the
export-D78747980
branch
from
5506fc1 to
af3b829
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78747980 |
allenwang28
added a commit
to allenwang28/monarch-1
that referenced
this pull request
Jul 23, 2025
Summary: Changes: - test_python_actors was failing due to rust bindings. This moves RDMA manager creation into a classmethod - test_allocator was failing due to an aggressive regex. Relaxed this. - test_rdma had a typo in `needs_rdma` - in test_mailbox.py, for whatever reason the cast was taking a really long time to complete. The logic is the same without the cast. - fixes some logic in `HAS_TENSOR_ENGINE` for deciding on whether or not to start RDMA manager actor. - Disable `test_actor_mesh.py` tests. For some reason, after D78292490, this test stopped cleaning up properly which affects downstream tests when running sequentially. Specifically, `builtins/test_log.py` and `builtins/test_random.py`. Syncing with pzhan9, there's currently an issue where unclean shutdown can lead to fatal error that's being actively worked on. We should re-enable these tests once that is resolved. remaining failures that are marked as skipped in OSS: - test_actor_error::test_supervision_with_sending_error - test_controller:: test_timeout_warning These tests seem to fail when run in isolation, but fail when run sequentially. Differential Revision: D78747980
allenwang28
force-pushed
the
export-D78747980
branch
from
af3b829 to
f27759d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78747980 |
Summary: Changes: - test_python_actors was failing due to rust bindings. This moves RDMA manager creation into a classmethod - test_allocator was failing due to an aggressive regex. Relaxed this. - test_rdma had a typo in `needs_rdma` - in test_mailbox.py, for whatever reason the cast was taking a really long time to complete. The logic is the same without the cast. - fixes some logic in `HAS_TENSOR_ENGINE` for deciding on whether or not to start RDMA manager actor. - Disable `test_actor_mesh.py` tests. For some reason, after D78292490, this test stopped cleaning up properly which affects downstream tests when running sequentially. Specifically, `builtins/test_log.py` and `builtins/test_random.py`. Syncing with pzhan9, there's currently an issue where unclean shutdown can lead to fatal error that's being actively worked on. We should re-enable these tests once that is resolved. remaining failures that are marked as skipped in OSS: - test_actor_error::test_supervision_with_sending_error - test_controller:: test_timeout_warning These tests seem to fail when run in isolation, but fail when run sequentially. Differential Revision: D78747980
allenwang28
force-pushed
the
export-D78747980
branch
from
f27759d to
0b60611
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78747980 |
|
This pull request has been merged in b3fcd71. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D78747980
Fixes:
Changes:
test_allocator was failing due to an aggressive regex. Relaxed this.
This doesn't fix all of the tests. Remaining failures: