Fix debugger test #590
Closed
Fix debugger test #590
+54
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D78585722 broke test_debug and somehow the tests don't run on diffs. This adds the necessary annotations to make it ok for the debugger code to block the existing event loop while it is doing debugging stuff. Differential Revision: [D78634155](https://our.internmc.facebook.com/intern/diff/D78634155/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78634155/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jul 20, 2025
D78585722 broke test_debug and somehow the tests don't run on diffs. This adds the necessary annotations to make it ok for the debugger code to block the existing event loop while it is doing debugging stuff. Differential Revision: [D78634155](https://our.internmc.facebook.com/intern/diff/D78634155/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78634155/)! ghstack-source-id: 297383325 Pull Request resolved: #590
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78634155 |
D78585722 broke test_debug and somehow the tests don't run on diffs. This adds the necessary annotations to make it ok for the debugger code to block the existing event loop while it is doing debugging stuff. Differential Revision: [D78634155](https://our.internmc.facebook.com/intern/diff/D78634155/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78634155/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jul 21, 2025
Pull Request resolved: #590 D78585722 broke test_debug and somehow the tests don't run on diffs. This adds the necessary annotations to make it ok for the debugger code to block the existing event loop while it is doing debugging stuff. ghstack-source-id: 297498052 @exported-using-ghexport Differential Revision: [D78634155](https://our.internmc.facebook.com/intern/diff/D78634155/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78634155/)!
|
This pull request was exported from Phabricator. Differential Revision: D78634155 |
D78585722 broke test_debug and somehow the tests don't run on diffs. This adds the necessary annotations to make it ok for the debugger code to block the existing event loop while it is doing debugging stuff. Differential Revision: [D78634155](https://our.internmc.facebook.com/intern/diff/D78634155/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78634155/)! [ghstack-poisoned]
zdevito
added a commit
that referenced
this pull request
Jul 21, 2025
Pull Request resolved: #590 D78585722 broke test_debug and somehow the tests don't run on diffs. This adds the necessary annotations to make it ok for the debugger code to block the existing event loop while it is doing debugging stuff. ghstack-source-id: 297501867 @exported-using-ghexport Differential Revision: [D78634155](https://our.internmc.facebook.com/intern/diff/D78634155/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D78634155/)!
|
This pull request was exported from Phabricator. Differential Revision: D78634155 |
|
This pull request has been merged in 2ff2097. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
D78585722 broke test_debug and somehow the tests don't run on diffs.
This adds the necessary annotations to make it ok for the debugger code to block the existing event loop while it is doing debugging stuff.
Differential Revision: D78634155
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!