: supervision: new enum Unhealthy #569
Closed
+71
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78498195 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
- introduced new type `supervision::Unhealthy`
```rust
#[derive(Debug, Clone)]
pub(crate) enum Unhealthy<Event> {
SoFarSoGood, // Still healthy
StreamClosed, // Event stream closed
Crashed(Event), // Bad health event received
}
```
- in `PyProcMesh`
- replace:
- from`Arc<Mutex<Option<Option<ProcEvent>>>>`
- to `Arc<Mutex<Unhealthy<ProcEvent>>>`
- in `PythonActorMesh`
- replace:
- from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>`
- to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>`
Differential Revision: D78498195
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
- introduced new type `supervision::Unhealthy`
```rust
#[derive(Debug, Clone)]
pub(crate) enum Unhealthy<Event> {
SoFarSoGood, // Still healthy
StreamClosed, // Event stream closed
Crashed(Event), // Bad health event received
}
```
- in `PyProcMesh`
- replace:
- from`Arc<Mutex<Option<Option<ProcEvent>>>>`
- to `Arc<Mutex<Unhealthy<ProcEvent>>>`
- in `PythonActorMesh`
- replace:
- from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>`
- to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>`
Differential Revision: D78498195
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
- introduced new type `supervision::Unhealthy`
```rust
#[derive(Debug, Clone)]
pub(crate) enum Unhealthy<Event> {
SoFarSoGood, // Still healthy
StreamClosed, // Event stream closed
Crashed(Event), // Bad health event received
}
```
- in `PyProcMesh`
- replace:
- from`Arc<Mutex<Option<Option<ProcEvent>>>>`
- to `Arc<Mutex<Unhealthy<ProcEvent>>>`
- in `PythonActorMesh`
- replace:
- from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>`
- to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>`
Differential Revision: D78498195
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
- introduced new type `supervision::Unhealthy`
```rust
#[derive(Debug, Clone)]
pub(crate) enum Unhealthy<Event> {
SoFarSoGood, // Still healthy
StreamClosed, // Event stream closed
Crashed(Event), // Bad health event received
}
```
- in `PyProcMesh`
- replace:
- from`Arc<Mutex<Option<Option<ProcEvent>>>>`
- to `Arc<Mutex<Unhealthy<ProcEvent>>>`
- in `PythonActorMesh`
- replace:
- from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>`
- to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>`
Differential Revision: D78498195
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
- introduced new type `supervision::Unhealthy`
```rust
#[derive(Debug, Clone)]
pub(crate) enum Unhealthy<Event> {
SoFarSoGood, // Still healthy
StreamClosed, // Event stream closed
Crashed(Event), // Bad health event received
}
```
- in `PyProcMesh`
- replace:
- from`Arc<Mutex<Option<Option<ProcEvent>>>>`
- to `Arc<Mutex<Unhealthy<ProcEvent>>>`
- in `PythonActorMesh`
- replace:
- from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>`
- to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>`
Differential Revision: D78498195
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
- introduced new type `supervision::Unhealthy`
```rust
#[derive(Debug, Clone)]
pub(crate) enum Unhealthy<Event> {
SoFarSoGood, // Still healthy
StreamClosed, // Event stream closed
Crashed(Event), // Bad health event received
}
```
- in `PyProcMesh`
- replace:
- from`Arc<Mutex<Option<Option<ProcEvent>>>>`
- to `Arc<Mutex<Unhealthy<ProcEvent>>>`
- in `PythonActorMesh`
- replace:
- from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>`
- to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>`
Differential Revision: D78498195
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 18, 2025
Summary:
- introduced new type `supervision::Unhealthy`
```rust
#[derive(Debug, Clone)]
pub(crate) enum Unhealthy<Event> {
SoFarSoGood, // Still healthy
StreamClosed, // Event stream closed
Crashed(Event), // Bad health event received
}
```
- in `PyProcMesh`
- replace:
- from`Arc<Mutex<Option<Option<ProcEvent>>>>`
- to `Arc<Mutex<Unhealthy<ProcEvent>>>`
- in `PythonActorMesh`
- replace:
- from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>`
- to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>`
Differential Revision: D78498195
shayne-fletcher
force-pushed
the
export-D78498195
branch
from
17c2834 to
05b5449
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78498195 |
shayne-fletcher
force-pushed
the
export-D78498195
branch
from
05b5449 to
a0808e7
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 21, 2025
Summary:
- introduced new type `supervision::Unhealthy`
```rust
#[derive(Debug, Clone)]
pub(crate) enum Unhealthy<Event> {
SoFarSoGood, // Still healthy
StreamClosed, // Event stream closed
Crashed(Event), // Bad health event received
}
```
- in `PyProcMesh`
- replace:
- from`Arc<Mutex<Option<Option<ProcEvent>>>>`
- to `Arc<Mutex<Unhealthy<ProcEvent>>>`
- in `PythonActorMesh`
- replace:
- from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>`
- to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>`
Reviewed By: pablorfb-meta
Differential Revision: D78498195
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 21, 2025
Summary:
- introduced new type `supervision::Unhealthy`
```rust
#[derive(Debug, Clone)]
pub(crate) enum Unhealthy<Event> {
SoFarSoGood, // Still healthy
StreamClosed, // Event stream closed
Crashed(Event), // Bad health event received
}
```
- in `PyProcMesh`
- replace:
- from`Arc<Mutex<Option<Option<ProcEvent>>>>`
- to `Arc<Mutex<Unhealthy<ProcEvent>>>`
- in `PythonActorMesh`
- replace:
- from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>`
- to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>`
Reviewed By: pablorfb-meta
Differential Revision: D78498195
shayne-fletcher
force-pushed
the
export-D78498195
branch
from
a0808e7 to
b36639a
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 21, 2025
Summary:
- introduced new type `supervision::Unhealthy`
```rust
#[derive(Debug, Clone)]
pub(crate) enum Unhealthy<Event> {
SoFarSoGood, // Still healthy
StreamClosed, // Event stream closed
Crashed(Event), // Bad health event received
}
```
- in `PyProcMesh`
- replace:
- from`Arc<Mutex<Option<Option<ProcEvent>>>>`
- to `Arc<Mutex<Unhealthy<ProcEvent>>>`
- in `PythonActorMesh`
- replace:
- from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>`
- to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>`
Reviewed By: pablorfb-meta
Differential Revision: D78498195
shayne-fletcher
force-pushed
the
export-D78498195
branch
from
b36639a to
82d18e9
Compare
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 21, 2025
Summary:
- introduced new type `supervision::Unhealthy`
```rust
#[derive(Debug, Clone)]
pub(crate) enum Unhealthy<Event> {
SoFarSoGood, // Still healthy
StreamClosed, // Event stream closed
Crashed(Event), // Bad health event received
}
```
- in `PyProcMesh`
- replace:
- from`Arc<Mutex<Option<Option<ProcEvent>>>>`
- to `Arc<Mutex<Unhealthy<ProcEvent>>>`
- in `PythonActorMesh`
- replace:
- from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>`
- to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>`
Reviewed By: pablorfb-meta
Differential Revision: D78498195
shayne-fletcher
force-pushed
the
export-D78498195
branch
from
82d18e9 to
3b2bdc7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78498195 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 21, 2025
Summary: Pull Request resolved: pytorch-labs#569 - introduced new type `supervision::Unhealthy` ```rust #[derive(Debug, Clone)] pub(crate) enum Unhealthy<Event> { SoFarSoGood, // Still healthy StreamClosed, // Event stream closed Crashed(Event), // Bad health event received } ``` - in `PyProcMesh` - replace: - from`Arc<Mutex<Option<Option<ProcEvent>>>>` - to `Arc<Mutex<Unhealthy<ProcEvent>>>` - in `PythonActorMesh` - replace: - from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>` - to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>` Reviewed By: pablorfb-meta Differential Revision: D78498195
shayne-fletcher
force-pushed
the
export-D78498195
branch
from
3b2bdc7 to
e29cbee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78498195 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 21, 2025
Summary: Pull Request resolved: pytorch-labs#569 - introduced new type `supervision::Unhealthy` ```rust #[derive(Debug, Clone)] pub(crate) enum Unhealthy<Event> { SoFarSoGood, // Still healthy StreamClosed, // Event stream closed Crashed(Event), // Bad health event received } ``` - in `PyProcMesh` - replace: - from`Arc<Mutex<Option<Option<ProcEvent>>>>` - to `Arc<Mutex<Unhealthy<ProcEvent>>>` - in `PythonActorMesh` - replace: - from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>` - to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>` Reviewed By: pablorfb-meta Differential Revision: D78498195
shayne-fletcher
force-pushed
the
export-D78498195
branch
from
e29cbee to
e5c742f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78498195 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 21, 2025
Summary: Pull Request resolved: pytorch-labs#569 - introduced new type `supervision::Unhealthy` ```rust #[derive(Debug, Clone)] pub(crate) enum Unhealthy<Event> { SoFarSoGood, // Still healthy StreamClosed, // Event stream closed Crashed(Event), // Bad health event received } ``` - in `PyProcMesh` - replace: - from`Arc<Mutex<Option<Option<ProcEvent>>>>` - to `Arc<Mutex<Unhealthy<ProcEvent>>>` - in `PythonActorMesh` - replace: - from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>` - to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>` Reviewed By: pablorfb-meta Differential Revision: D78498195
shayne-fletcher
force-pushed
the
export-D78498195
branch
from
e5c742f to
88ad8eb
Compare
Summary: Pull Request resolved: pytorch-labs#569 - introduced new type `supervision::Unhealthy` ```rust #[derive(Debug, Clone)] pub(crate) enum Unhealthy<Event> { SoFarSoGood, // Still healthy StreamClosed, // Event stream closed Crashed(Event), // Bad health event received } ``` - in `PyProcMesh` - replace: - from`Arc<Mutex<Option<Option<ProcEvent>>>>` - to `Arc<Mutex<Unhealthy<ProcEvent>>>` - in `PythonActorMesh` - replace: - from: `Arc<Mutex<Option<Option<ActorSupervisionEvent>>>>` - to: `Arc<Mutex<Unhealthy<ActorSupervisionEvent>>` Reviewed By: pablorfb-meta Differential Revision: D78498195
|
This pull request was exported from Phabricator. Differential Revision: D78498195 |
shayne-fletcher
force-pushed
the
export-D78498195
branch
from
88ad8eb to
60a0441
Compare
|
This pull request has been merged in 7dd0b25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
supervision::UnhealthyPyProcMeshArc<Mutex<Option<Option<ProcEvent>>>>Arc<Mutex<Unhealthy<ProcEvent>>>PythonActorMeshArc<Mutex<Option<Option<ActorSupervisionEvent>>>>Arc<Mutex<Unhealthy<ActorSupervisionEvent>>Differential Revision: D78498195