Add auto-reload support to CodeSyncManager
#568
Closed
+310
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78358200 |
andrewjcg
force-pushed
the
export-D78358200
branch
from
9ebe944 to
aef47cc
Compare
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 17, 2025
Summary: Pull Request resolved: pytorch-labs#568 Update the `CodeSyncManager` actor to call `AutoReloadActor` when requested, to trigger hot-reloading of Python code after code sync completes. In this setup, only a single `CodeSyncManager` on an e.g. host will perform a code sync operation, and then will cast to all ranks that share the host (e.g. gpu ranks) to trigger all the reloads. Differential Revision: D78358200
|
This pull request was exported from Phabricator. Differential Revision: D78358200 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D78358200 |
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 17, 2025
Summary: Pull Request resolved: pytorch-labs#568 Update the `CodeSyncManager` actor to call `AutoReloadActor` when requested, to trigger hot-reloading of Python code after code sync completes. In this setup, only a single `CodeSyncManager` on an e.g. host will perform a code sync operation, and then will cast to all ranks that share the host (e.g. gpu ranks) to trigger all the reloads. Differential Revision: D78358200
andrewjcg
force-pushed
the
export-D78358200
branch
2 times, most recently
from
a1667b6 to
a3f6a97
Compare
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 18, 2025
Summary: Update the `CodeSyncManager` actor to call `AutoReloadActor` when requested, to trigger hot-reloading of Python code after code sync completes. In this setup, only a single `CodeSyncManager` on an e.g. host will perform a code sync operation, and then will cast to all ranks that share the host (e.g. gpu ranks) to trigger all the reloads. Differential Revision: D78358200
|
This pull request was exported from Phabricator. Differential Revision: D78358200 |
andrewjcg
force-pushed
the
export-D78358200
branch
from
a3f6a97 to
43abfcd
Compare
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 19, 2025
Summary: Update the `CodeSyncManager` actor to call `AutoReloadActor` when requested, to trigger hot-reloading of Python code after code sync completes. In this setup, only a single `CodeSyncManager` on an e.g. host will perform a code sync operation, and then will cast to all ranks that share the host (e.g. gpu ranks) to trigger all the reloads. Differential Revision: D78358200
andrewjcg
force-pushed
the
export-D78358200
branch
from
43abfcd to
e8b28f7
Compare
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 19, 2025
Summary: Update the `CodeSyncManager` actor to call `AutoReloadActor` when requested, to trigger hot-reloading of Python code after code sync completes. In this setup, only a single `CodeSyncManager` on an e.g. host will perform a code sync operation, and then will cast to all ranks that share the host (e.g. gpu ranks) to trigger all the reloads. Differential Revision: D78358200
|
This pull request was exported from Phabricator. Differential Revision: D78358200 |
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 19, 2025
Summary: Pull Request resolved: pytorch-labs#568 Update the `CodeSyncManager` actor to call `AutoReloadActor` when requested, to trigger hot-reloading of Python code after code sync completes. In this setup, only a single `CodeSyncManager` on an e.g. host will perform a code sync operation, and then will cast to all ranks that share the host (e.g. gpu ranks) to trigger all the reloads. Differential Revision: D78358200
andrewjcg
force-pushed
the
export-D78358200
branch
from
e8b28f7 to
66e155c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78358200 |
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 19, 2025
Summary: Pull Request resolved: pytorch-labs#568 Update the `CodeSyncManager` actor to call `AutoReloadActor` when requested, to trigger hot-reloading of Python code after code sync completes. In this setup, only a single `CodeSyncManager` on an e.g. host will perform a code sync operation, and then will cast to all ranks that share the host (e.g. gpu ranks) to trigger all the reloads. Differential Revision: D78358200
andrewjcg
force-pushed
the
export-D78358200
branch
2 times, most recently
from
78e4181 to
753ee3f
Compare
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 21, 2025
Summary: Update the `CodeSyncManager` actor to call `AutoReloadActor` when requested, to trigger hot-reloading of Python code after code sync completes. In this setup, only a single `CodeSyncManager` on an e.g. host will perform a code sync operation, and then will cast to all ranks that share the host (e.g. gpu ranks) to trigger all the reloads. Reviewed By: highker Differential Revision: D78358200
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 21, 2025
Summary: Update the `CodeSyncManager` actor to call `AutoReloadActor` when requested, to trigger hot-reloading of Python code after code sync completes. In this setup, only a single `CodeSyncManager` on an e.g. host will perform a code sync operation, and then will cast to all ranks that share the host (e.g. gpu ranks) to trigger all the reloads. Reviewed By: highker Differential Revision: D78358200
andrewjcg
force-pushed
the
export-D78358200
branch
from
753ee3f to
c93afad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78358200 |
andrewjcg
added a commit
to andrewjcg/monarch
that referenced
this pull request
Jul 21, 2025
Summary: Pull Request resolved: pytorch-labs#568 Update the `CodeSyncManager` actor to call `AutoReloadActor` when requested, to trigger hot-reloading of Python code after code sync completes. In this setup, only a single `CodeSyncManager` on an e.g. host will perform a code sync operation, and then will cast to all ranks that share the host (e.g. gpu ranks) to trigger all the reloads. Reviewed By: highker Differential Revision: D78358200
andrewjcg
force-pushed
the
export-D78358200
branch
from
c93afad to
a70e53d
Compare
Summary: Pull Request resolved: pytorch-labs#568 Update the `CodeSyncManager` actor to call `AutoReloadActor` when requested, to trigger hot-reloading of Python code after code sync completes. In this setup, only a single `CodeSyncManager` on an e.g. host will perform a code sync operation, and then will cast to all ranks that share the host (e.g. gpu ranks) to trigger all the reloads. Reviewed By: highker Differential Revision: D78358200
|
This pull request was exported from Phabricator. Differential Revision: D78358200 |
andrewjcg
force-pushed
the
export-D78358200
branch
from
a70e53d to
3fbda0f
Compare
|
This pull request has been merged in 4cf5147. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update the
CodeSyncManageractor to callAutoReloadActorwhen requested, to trigger hot-reloading of Python code after
code sync completes.
In this setup, only a single
CodeSyncManageron an e.g. hostwill perform a code sync operation, and then will cast to all ranks
that share the host (e.g. gpu ranks) to trigger all the reloads.
Differential Revision: D78358200