Skip to content

Fix python port serialization #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

zdevito
Copy link
Contributor

@zdevito zdevito commented Jul 16, 2025

Stack from ghstack (oldest at bottom):

This was regressed when we switched from serializable PortId objects into rust-bound PythonPortRef objects.

Restore serialization by defining new/reduce pair.

Differential Revision: D78438687

This was regressed when we switched from serializable PortId objects into rust-bound PythonPortRef objects.

Restore serialization by defining new/__reduce__ pair.

Differential Revision: [D78438687](https://our.internmc.facebook.com/intern/diff/D78438687/)

[ghstack-poisoned]
zdevito added a commit that referenced this pull request Jul 16, 2025
This was regressed when we switched from serializable PortId objects into rust-bound PythonPortRef objects.

Restore serialization by defining new/__reduce__ pair.

Differential Revision: [D78438687](https://our.internmc.facebook.com/intern/diff/D78438687/)

ghstack-source-id: 296655361
Pull Request resolved: #560
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 16, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78438687

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in bfac79b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants