Skip to content

Add hl.dot() API; Use hl.dot instead of torch.matmul for FP8 GEMM ops in Helion kernel #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2025
Merged

Add hl.dot() API; Use hl.dot instead of torch.matmul for FP8 GEMM ops in Helion kernel #356

merged 1 commit into from
Jul 27, 2025

Conversation

yf225
Copy link
Contributor

@yf225 yf225 commented Jul 23, 2025 •
edited
Loading

yf225 added a commit that referenced this pull request Jul 23, 2025
@yf225
Use torch._scaled_mm instead of torch.matmul for fp8_gemm and fp8_att…
9783e21 
…ention

stack-info: PR: #356, branch: yf225/stack/39
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 23, 2025
@yf225 yf225 requested review from jansel, oulgen, ngimel and drisspg July 23, 2025 06:34
@yf225 yf225 changed the title Use torch._scaled_mm instead of torch.matmul for fp8_gemm and fp8_attention Use torch._scaled_mm instead of torch.matmul for FP8 GEMM ops in Helion kernel Jul 23, 2025
yf225 added a commit that referenced this pull request Jul 23, 2025
@yf225
Use torch._scaled_mm instead of torch.matmul for FP8 GEMM ops in Heli…
94ad882 
…on kernel

stack-info: PR: #356, branch: yf225/stack/39
@yf225 yf225 mentioned this pull request Jul 23, 2025
Merged
drisspg
drisspg reviewed Jul 23, 2025
View reviewed changes
drisspg
drisspg reviewed Jul 23, 2025
View reviewed changes
yf225
yf225 commented Jul 23, 2025
View reviewed changes
@yf225 yf225 force-pushed the yf225/stack/39 branch 3 times, most recently from 5c8fc17 to 854097f Compare July 23, 2025 23:43
drisspg
drisspg reviewed Jul 24, 2025
View reviewed changes
jansel
jansel requested changes Jul 24, 2025
View reviewed changes
@yf225 yf225 force-pushed the yf225/stack/39 branch 2 times, most recently from 13367e2 to 79c6e16 Compare July 24, 2025 23:57
@yf225 yf225 requested a review from jansel July 25, 2025 00:02
jansel
jansel requested changes Jul 25, 2025
View reviewed changes
@yf225 yf225 mentioned this pull request Jul 25, 2025
Closed
@yf225 yf225 changed the title Use torch._scaled_mm instead of torch.matmul for FP8 GEMM ops in Helion kernel Use hl.dot instead of torch.matmul for FP8 GEMM ops in Helion kernel Jul 25, 2025
@yf225 yf225 force-pushed the yf225/stack/39 branch 2 times, most recently from ea34fe8 to 9e3aaa2 Compare July 25, 2025 23:01
jansel
jansel reviewed Jul 26, 2025
View reviewed changes
@yf225 yf225 force-pushed the yf225/stack/39 branch 4 times, most recently from 1f56955 to d0812a3 Compare July 26, 2025 19:22
@yf225 yf225 mentioned this pull request Jul 26, 2025
Closed
@yf225 yf225 changed the base branch from main to yf225/stack/43 July 26, 2025 19:22
@yf225 yf225 changed the base branch from yf225/stack/43 to main July 26, 2025 19:42
@yf225 yf225 changed the base branch from main to yf225/stack/43 July 26, 2025 19:42
@yf225 yf225 changed the base branch from yf225/stack/43 to main July 26, 2025 19:51
@yf225 yf225 changed the title Use hl.dot instead of torch.matmul for FP8 GEMM ops in Helion kernel Add hl.dot() API; Use hl.dot instead of torch.matmul for FP8 GEMM ops in Helion kernel Jul 26, 2025
@yf225 yf225 force-pushed the yf225/stack/39 branch 4 times, most recently from aea7799 to e36865a Compare July 26, 2025 21:01
@yf225 yf225 requested a review from jansel July 26, 2025 21:13
@yf225 yf225 force-pushed the yf225/stack/39 branch 3 times, most recently from 3def4e6 to f130e9d Compare July 26, 2025 23:30
@yf225
Add hl.dot() API; Use hl.dot instead of torch.matmul for FP8 GEMM ops…
1cee7d4 
… in Helion kernel

stack-info: PR: #356, branch: yf225/stack/39
yf225 added a commit that referenced this pull request Jul 27, 2025
@yf225
Add hl.dot() API; Use hl.dot instead of torch.matmul for FP8 GEMM ops…
75cfd66 
… in Helion kernel

stack-info: PR: #356, branch: yf225/stack/39
yf225 added a commit that referenced this pull request Jul 27, 2025
@yf225
Add hl.dot() API; Use hl.dot instead of torch.matmul for FP8 GEMM ops…
90a9c6c 
… in Helion kernel

stack-info: PR: #356, branch: yf225/stack/39
@yf225 yf225 merged commit 2a9aa70 into main Jul 27, 2025
7 checks passed
yf225 added a commit that referenced this pull request Jul 27, 2025
@yf225
Revert "Add hl.dot() API; Use hl.dot instead of torch.matmul for FP8 …
61dad12 
…GEMM ops in Helion kernel (#356)"

This reverts commit 2a9aa70.
@yf225 yf225 mentioned this pull request Jul 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drisspg drisspg drisspg approved these changes

@jansel jansel jansel approved these changes

@oulgen oulgen Awaiting requested review from oulgen

@ngimel ngimel Awaiting requested review from ngimel

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yf225 @jansel @drisspg @facebook-github-bot