[networkx] Correct argument type for from_nested_tuple #14218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the type hint specifies a tuple of length one with an arbitrary element. However the tuple passed may be of any length. It is actually an arbitrary nested tuple of tuples but not sure how to annotate that or if it's necessary.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Avasam
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
Thanks!
For nested tuples: I think you can make a self-referencial type-alias. Something like
_T = TypeVar("_T")
_NestedTuple: TypeAlias = tuple[_NestedTuple | _T, ...]
# Usage:
_NestedTuple[str]But your current fix is perfectly fine as is. You can explore a more complete annotation in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the type hint specifies a tuple of length one with an arbitrary element. However the tuple passed may be of any length. It is actually an arbitrary nested tuple of tuples but not sure how to annotate that or if it's necessary.