Skip to content

Conversation

@skirpichev
Copy link
Contributor

@skirpichev skirpichev commented May 21, 2025

  • add submodule variant
  • add Rationale section
  • expand Motivation
  • rename module, move "Module name" section
  • disband "Open Issues"
  • mention intmath package

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--4430.org.readthedocs.build/pep-0791/

@skirpichev skirpichev force-pushed the pep791-address-comments branch 2 times, most recently from 963f154 to 86e15a2 Compare May 24, 2025 06:34
@skirpichev skirpichev force-pushed the pep791-address-comments branch from 86e15a2 to 8cdce7a Compare May 24, 2025 06:37
@skirpichev skirpichev marked this pull request as ready for review May 24, 2025 06:38
@skirpichev skirpichev requested a review from vstinner as a code owner May 24, 2025 06:38
@skirpichev

This comment was marked as resolved.

@skirpichev

This comment was marked as resolved.

@skirpichev skirpichev requested review from vstinner and zooba May 29, 2025 14:49
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skirpichev skirpichev force-pushed the pep791-address-comments branch from 177f73b to ae03c4b Compare June 3, 2025 11:05
@skirpichev skirpichev requested a review from vstinner June 3, 2025 11:05
@skirpichev
Copy link
Contributor Author

@vstinner, "Open Issues" section was removed. Please review.

@serhiy-storchaka, I would appreciate your feedback as this is close to final version (for SC). Let me know if you feel that argumentation is not strong enough. I think it's better to mark this PEP as "Deferred" than reject the idea.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skirpichev
Copy link
Contributor Author

@vstinner, perhaps this can be merged, regardless on Serhiy feedback?

@vstinner vstinner merged commit 0465dd1 into python:main Aug 4, 2025
5 checks passed
@vstinner
Copy link
Member

vstinner commented Aug 4, 2025

Merged, thanks.

@skirpichev skirpichev deleted the pep791-address-comments branch August 4, 2025 13:17
@skirpichev
Copy link
Contributor Author

Thanks, I'll go through comments again to see if I miss something (it seems I did). Would it be ok just update thread by a new post or it's better to start a new thread?

@vstinner
Copy link
Member

vstinner commented Aug 5, 2025

Would it be ok just update thread by a new post or it's better to start a new thread?

You can just send a new message in the existing thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants