Skip to content

gh-152216: Silence expat compiler warnings#153671

Closed
cdce8p wants to merge 1 commit into
python:mainfrom
cdce8p:silence-expat-compiler-warnings
Closed

gh-152216: Silence expat compiler warnings#153671
cdce8p wants to merge 1 commit into
python:mainfrom
cdce8p:silence-expat-compiler-warnings

Conversation

@cdce8p

@cdce8p cdce8p commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Silence expat compiler warnings on macOS with clang.

In file included from ./Modules/expat/xmltok.c:309:
./Modules/expat/xmltok_impl.c:283:5: warning: fallthrough annotation in unreachable code [-Wunreachable-code-fallthrough]
  283 |     CHECK_NMSTRT_CASES(enc, ptr, end, nextTokPtr)
      |     ^
./Modules/expat/xmltok_impl.c:116:5: note: expanded from macro 'CHECK_NMSTRT_CASES'
  116 |     EXPAT_FALLTHROUGH;                                                         \
      |     ^
./Modules/expat/fallthrough.h:45:33: note: expanded from macro 'EXPAT_FALLTHROUGH'
   45 | #      define EXPAT_FALLTHROUGH __attribute__((fallthrough))
      |                                 ^
...

@StanFromIreland

Copy link
Copy Markdown
Member

As I noted in the issue, we won't be doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants