-
Notifications
You must be signed in to change notification settings - Fork 2.4k
change default of installer.re-resolve from true to false
#10622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
radoering
wants to merge
1
commit into
python-poetry:main
Choose a base branch
from
radoering:installer-reresolve-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
change default of installer.re-resolve from true to false
#10622
radoering
wants to merge
1
commit into
python-poetry:main
from
radoering:installer-reresolve-default
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR inverts the default of installer.re-resolve to false by updating the Config default and installer logic, aligning tests to expect the new default, and adjusting documentation accordingly. Class diagram for updated Config defaultsclassDiagram
class Config {
+installer: dict
}
class Installer {
-_config: Config
+_do_install()
}
Config <|-- Installer
Config : installer["re-resolve"] = False
Flow diagram for installer.re-resolve default logicflowchart TD
A["Start installation"] --> B["Read installer.re-resolve from config (default: false)"]
B --> C{Is re-resolve true?}
C -- Yes --> D["Perform re-resolve logic"]
C -- No --> E["Skip re-resolve logic"]
D --> F["Continue installation"]
E --> F
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
Resolves: #10617
We have probably reached a point where installation without re-resolving is stable enough to make it the default. Making it the default may reveal new bugs but on the other side #10617 (comment) shows that the old way has its own bugs.
Summary by Sourcery
Change the default behavior of the installer to disable re-resolving dependencies by default and update associated configuration, documentation, and tests.
Enhancements:
Documentation:
Tests: