Revamp scripts #10
Revamp scripts #10
Conversation
thmzlt
force-pushed
the
fogo-refactor
branch
from
dc81513 to
72cb295
Compare
| @@ -1,14 +1,17 @@ | |||
| [toolchain] | |||
There was a problem hiding this comment.
this section seems emtpy
| newAuthority: newAuthority, | ||
| programAccount: programToTransfer, | ||
| }) | ||
| .accountsPartial({ |
There was a problem hiding this comment.
normally you only pass one of accounts or accountsPartial
also PDAs are usually derived automatically, you can probably get away without specifying escrowAuthority and even programData in recent versions of anchor. if it's failing to derive them, make an accountsPartial block with all the accounts
| transaction: T | ||
| ): Promise<T> { | ||
| if (transaction instanceof VersionedTransaction) { | ||
| throw new Error("VersionedTransaction not supported by Ledger"); |
There was a problem hiding this comment.
check https://github.com/fogo-foundation/fogo-sessions/blob/main/scripts/ts/src/ledger.ts#L127 for a more updated version that supports VersionedTransaction too
| if (multisigAddress) { | ||
| [newAuthority] = getAuthorityPDA( | ||
| multisigAddress, | ||
| new BN(1), |
There was a problem hiding this comment.
I think you're supposed to use the authority index that's specified in the multisig account (you can get it by calling getMultisig)
|
|
||
| TypeScript scripts are provided to interact with the on-chain program. All scripts support: | ||
| - File-based keypairs or Ledger hardware wallets | ||
| - Squads v3 multisig proposals via `--multisig` |
There was a problem hiding this comment.
the transfer and revert scripts don't really support squads. To support squads you need to let currentAuthority be a multisigAuthority
2 participants
This updates the set of included scripts to call the propose/accept/revert instructions of the main program-authority-escrow program with support for file keys, Ledger wallets, and Squads v3 multisigs.