pytester: a couple of fixes for pytester.plugins in subprocess mode
#13522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
force-pushed
the
pytester-subprocess-plugins
branch
from
64151cf to
3a094ee
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
nicoddemus
approved these changes
Jun 16, 2025
…he first As far as I can see, there is no reason for this, seems like a mistake.
…ead of silently ignoring In subprocess mode, adding a non-str plugin object to `pytester.plugins` can't work. Previously, such plugins would just be silently ignored. Silently ignoring an explicit setup doesn't seem right. Error instead.
bluetech
force-pushed
the
pytester-subprocess-plugins
branch
from
3a094ee to
6669073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the commit messages.
This is just from looking at the code, didn't run into this personally. I think there is no reason to backport.