Platescale conversion and trace_maxshift param in echelle object finding#2128
Open
debora-pe wants to merge 6 commits into
Open
Platescale conversion and trace_maxshift param in echelle object finding#2128debora-pe wants to merge 6 commits into
trace_maxshift param in echelle object finding#2128debora-pe wants to merge 6 commits into
Conversation
bpholden
reviewed
May 20, 2026
bpholden
reviewed
May 20, 2026
Collaborator
Author
|
Run the tests. There are some problems that are not related to this PR.
|
profxj
approved these changes
May 24, 2026
profxj
left a comment
Collaborator
There was a problem hiding this comment.
looks good to me, thanks
Collaborator
|
It's annoying that the data went away! Does anyone have a local copy? I do not. Was the data deleted because it's owned by silvia.onorato96 ? |
kbwestfall
requested changes
May 29, 2026
kbwestfall
left a comment
Collaborator
There was a problem hiding this comment.
Great! No comments from me, but I agree with everything Brad said, so I'm requesting changes.
kbwestfall
approved these changes
Jun 1, 2026
kbwestfall
left a comment
Collaborator
There was a problem hiding this comment.
I think I've now addressed Brad's comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During object finding, for objects which were only found on some orders, a trace is also added in orders where the objects were not found. Values from the nearest detected order are used to filled out the missing objects, but for spectrographs with different platescale per order, the pixel values will be different in arcsec. This PR fixes this inconsistency, by scaling the pixel values, such as FWHM, maskwidth, and BOX_R_PIX, to keep consistent arcsec values throughout all the orders.
The parameter
trace_maxshiftis now also used by echelle findobj methods, which can help to limit centroid shifts during iterative trace refinement, if more than one trace are present.Tests have been added in the Dev-Suite here: pypeit/PypeIt-development-suite#407