Adds compress-level option to sdist and wheel configs #1995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstigen
force-pushed
the
sdist-compress-level
branch
2 times, most recently
from
115e24a to
49da117
Compare
cstigen
changed the title
tool.hatch.build.targets.sdist.compress-level
cstigen
changed the title
cstigen
force-pushed
the
sdist-compress-level
branch
from
49da117 to
ab5af04
Compare
cstigen
force-pushed
the
sdist-compress-level
branch
from
ab5af04 to
d96b167
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using hatchling at work to bundle ~80 moderately large JSON files into an sdist tarball.
This takes ~50 seconds with the default gzip compression level of 9. With level 1 it takes only a few seconds at the expense of a few tens of megabytes. For us, this is a desirable trade-off, and I believe it could make sense for others as well.
Since I wasn't able to find any contribution docs I'm going to put this PR in draft mode. For example, I haven't made any tests.
Of course, I'm expecting some feedback on the merit of this idea as well.