Skip to content

Validate LoongArch LP64D and object ABI v1 - #753

Open
wxpppp wants to merge 1 commit into
pypa:mainfrom
wxpppp:loongarch64-abi-validation
Open

wxpppp wants to merge 1 commit into
pypa:mainfrom
wxpppp:loongarch64-abi-validation

Conversation

@wxpppp

@wxpppp wxpppp commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

As part of the proposed LoongArch64 manylinux/musllinux platform baseline discussed in the packaging discussion, this PR implements the ELF ABI checks for LP64D and object ABI v1.

The ELF machine identifier alone cannot distinguish incompatible LoongArch ABIs. Following auditwheel's existing ARM ABI-checking approach, this change checks the corresponding ELF flags when identifying supported loongarch64 binaries.

Binaries with unsupported ABI flags are treated as having an unknown architecture and skipped. A wheel with no matching ELF binaries is rejected.

The change also:

  • Raises the minimum pyelftools version to 0.30 for the LoongArch ELF constants.
  • Adds glibc and musl sample wheels and generation script support.
  • Adds unsupported-ABI tests and LoongArch cross-repair coverage.

Validation:

  • All unsupported-ABI tests passed locally.
  • Both generated samples were repaired and inspected successfully, yielding
    manylinux_2_36_loongarch64 and musllinux_1_2_loongarch64.
  • An ABI-incompatible SciPy wheel was rejected without producing an output wheel.

Check LP64D and object ABI v1 using the existing architecture filtering. Add reproducible glibc and musl wheel samples and integration coverage.
@codecov

codecov Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.09%. Comparing base (0dcd1a6) to head (e6fc12c).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
+ Coverage   96.08%   96.09%   +0.01%     
==========================================
  Files          23       23              
  Lines        2041     2048       +7     
  Branches      390      394       +4     
==========================================
+ Hits         1961     1968       +7     
  Misses         46       46              
  Partials       34       34              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mayeut
mayeut requested a balanced review from Copilot November 13, 2026 19:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants