Repository navigation
Keep the wheel component unique in CycloneDX SBOMs - #752
Merged
Merged
Conversation
auvipy
self-requested a review
November 10, 2026 17:40
JekaK
marked this pull request as ready for review
November 10, 2026 18:01
lkollar
approved these changes
Nov 12, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the SBOM wheel-component deduplication change.
No open issues 🎉
What changed in this PR
Fixes #750 by declaring the wheel component only once in generated CycloneDX SBOMs, while preserving its dependency links to grafted libraries.
Changes:
- Keeps the wheel in
metadata.componentand limitscomponentsto grafted libraries. - Updates unit and integration assertions to check wheel exclusion and dependency graph consistency.
- Documents the fix in the changelog.
| File | Description |
|---|---|
tests/unit/test_sboms.py |
Updates expected components and verifies deterministic library references and dependency links. |
tests/integration/test_manylinux.py |
Checks wheel exclusion and dependency links in the installed NumPy SBOM. |
src/auditwheel/sboms.py |
Defines the wheel solely in metadata, removing its duplicate component entry. |
CHANGELOG.md |
Adds a user-facing bugfix entry linked to #750. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
=========================================
+ Coverage 0 96.08% +96.08%
=========================================
Files 0 23 +23
Lines 0 2041 +2041
Branches 0 390 +390
=========================================
+ Hits 0 1961 +1961
- Misses 0 46 +46
- Partials 0 34 +34 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mayeut
approved these changes
Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #750.
When repair grafts a library, the generated BOM currently declares the wheel twice with the same bom-ref. Keep the wheel in metadata.component and list only grafted libraries in components. The dependency graph still points from the wheel to those libraries.
Tested on
369e83d695b0d89fdb61d7a5671ad15bc8d13473: 7 passed in 0.08s