-
-
Notifications
You must be signed in to change notification settings - Fork 299
Fix false positive no-member in except * handler #2786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matusvalo
wants to merge
8
commits into
pylint-dev:main
Choose a base branch
from
matusvalo:except_star
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
db4de99
Fix false positive no-member in except * handler
matusvalo 2ff716c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 863177d
Update changelog
matusvalo 69619ce
Use extract_node instead of direct class construction
matusvalo 13ad3db
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] c606d03
Make pylint happy
matusvalo 0f362f5
Make both ruff and pylint happy
matusvalo 66a4007
Merge branch 'main' into except_star
matusvalo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's clever but I'm not sure it's the right approach (maybe there's something more efficient ?). Maybe another maintainer will have ideas about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used it since it seemed to be standard way how to do it - e.g. here: https://github.com/pylint-dev/astroid/blob/8e19277598d5764f5afd821d7bb6104b701ac88f/astroid/brain/brain_collections.py#L120C32-L120C55