-
-
Notifications
You must be signed in to change notification settings - Fork 198
Add Color.__bytes__
#3547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Matiiss
wants to merge
5
commits into
pygame-community:main
Choose a base branch
from
Matiiss:add-color-bytes-method
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Color.__bytes__
#3547
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
da78307
implement the __bytes__ method and add a test case
Matiiss e0bf78a
add Color.__bytes__ to the stubs
Matiiss a6acbe6
Update src_c/color.c
Matiiss ae96a23
add comment clarifying why the magic dunder is defined as part of met…
Matiiss 68e8f05
add a versionchanged note
Matiiss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -181,6 +181,9 @@ _color_int(pgColorObject *); | |
static PyObject * | ||
_color_float(pgColorObject *); | ||
|
||
static PyObject * | ||
_color_bytes(pgColorObject *); | ||
|
||
/* Sequence protocol methods */ | ||
static Py_ssize_t | ||
_color_length(pgColorObject *); | ||
|
@@ -256,6 +259,17 @@ static PyMethodDef _color_methods[] = { | |
{"premul_alpha", (PyCFunction)_premul_alpha, METH_NOARGS, | ||
DOC_COLOR_PREMULALPHA}, | ||
{"update", (PyCFunction)_color_update, METH_FASTCALL, DOC_COLOR_UPDATE}, | ||
|
||
/** | ||
* While object.__bytes__(self) is listed in the Data Model reference (see: | ||
* https://docs.python.org/3/reference/datamodel.html#object.__bytes__) it | ||
* does not appear to have a PyTypeObject struct analog (see: | ||
* https://docs.python.org/3/c-api/typeobj.html), so we declare it for the | ||
* type as any other custom method. | ||
*/ | ||
Comment on lines
+263
to
+269
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure this giant comment is strictly necessary in the middle of this large array definition |
||
{"__bytes__", (PyCFunction)_color_bytes, METH_NOARGS, | ||
"Get a byte representation of the color"}, | ||
|
||
{NULL, NULL, 0, NULL}}; | ||
|
||
/** | ||
|
@@ -1753,6 +1767,15 @@ _color_float(pgColorObject *color) | |
return PyFloat_FromDouble((double)tmp); | ||
} | ||
|
||
/** | ||
* bytes(color) | ||
*/ | ||
static PyObject * | ||
_color_bytes(pgColorObject *color) | ||
{ | ||
return PyBytes_FromStringAndSize((char *)color->data, 4); | ||
} | ||
|
||
/* Sequence protocol methods */ | ||
|
||
/** | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think
versionadded
is more appropriate becauseversionchanged
indicates that we changed behavior on our end, instead of overriding default python behavior by adding a new method.