Expose top-level xarray.indexes in __init__ #10435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also expose CoordinateTransformIndex Closes pydata#10424
dcherian
commented
Jun 18, 2025
| @@ -1,6 +1,6 @@ | |||
| from importlib.metadata import version as _version | |||
|
|
|||
| from xarray import coders, groupers, testing, tutorial, ufuncs | |||
| from xarray import coders, groupers, indexes, testing, tutorial, ufuncs | |||
There was a problem hiding this comment.
this seems like an oversight
dcherian
commented
Jun 18, 2025
| @@ -4,10 +4,17 @@ | |||
| """ | |||
|
|
|||
| from xarray.core.indexes import ( | |||
| CoordinateTransformIndex, | |||
There was a problem hiding this comment.
@benbovy does this seem OK to you? Would be good for SciPy...
There was a problem hiding this comment.
Yes! We should also expose xarray.core.coordinate_transform.CoordinateTransform since we already subclass it externally (not sure in which namespace... indexes as well?).
benbovy
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also expose CoordinateTransformIndex
Closes #10424