fix: handle case-insensitive retrieval in GoogleSecretManagerSettingsSource #730
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #728.
This PR updates
GoogleSecretManagerMappingto support robust case-insensitive secret retrieval.Changes:
TEST_SECRET,mySecret) are correctly retrieved whencase_sensitive=False.MY_SECRETandmy_secret), the lexicographically last one (preferring lowercase) is chosen.UserWarningwhen such collisions occur.