Warn if model_config sets unused keys for missing settings sources #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hramezani
reviewed
Aug 1, 2025
hramezani
reviewed
Aug 1, 2025
|
Thanks @HomerusJa for the PR. I left some comments |
- Use a full BaseSettings instance - Check for exactly one warning message
hramezani
approved these changes
Aug 1, 2025
|
Thanks @HomerusJa |
|
Thanks for your help, @hramezani! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user now changes the value for one of the values for the other settings sources in the model_config but doesn't add these sources via settings_customise_sources, he will receive a descriptive UserWarning.
I added unit tests, but I would love it if someone could review them, as this is one of the first times I've written proper unit tests.
Closes #660