Skip to content

Update the JOSS plotting scripts and design plots #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NicolaCourtier wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Update the JOSS plotting scripts and design plots #966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef2285c
update joss plotting scripts
SarahRo Jul 17, 2026
4a4ef90
Update plotting scripts
NicolaCourtier Jul 21, 2026
06ee3c8
Update design plots
NicolaCourtier Jul 21, 2026
70a7b01
Merge branch 'develop' into joss-plots
NicolaCourtier Jul 21, 2026
62fd833
Update description
NicolaCourtier Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions papers/joss/design_plots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# A script to generate design optimisation plots for the JOSS paper.
"""
A script to generate design optimisation plots for the JOSS paper.

NOTE: The design optimisation plots that appear in Figure 8 of the paper were
unfortunately generated with a bug in simulator._create_experiment_simulation().
PR 857 fixed and replaced this function with simulator.create_simulation() in
January 2026. The two design plots in figures/individual and one in
figures/combined were updated in PR 966, July 2026.
"""

import numpy as np
import pybamm
Expand Down Expand Up @@ -43,7 +50,6 @@
- Parameter("Positive electrode active material volume fraction"),
"Cell mass [kg]": pybop.pybamm.cell_mass(),
},
check_already_exists=False,
)

# Fitting parameters
Expand Down
Binary file modified papers/joss/figures/combined/design.pdf
View file
Open in desktop
Binary file not shown.
Binary file modified papers/joss/figures/individual/design_gravimetric.pdf
View file
Open in desktop
Binary file not shown.
Binary file modified papers/joss/figures/individual/design_prediction.pdf
View file
Open in desktop
Binary file not shown.
6 changes: 4 additions & 2 deletions papers/joss/param_plots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# A script to generate parameterisation plots for the JOSS paper.

"""
A script to generate parameterisation plots for the JOSS paper.
"""

import matplotlib.pyplot as plt
import numpy as np
Expand Down Expand Up @@ -455,6 +456,7 @@
optim.optimiser.b1 = 0.85
optim.optimiser.b2 = 0.9
optim.optimiser.lam = 0.005
optim.optimiser._alpha = np.asarray([1.0, 0.22222222]) # noqa: SLF001 # retain the initial step size used for paper
if optimiser is pybop.GradientDescent:
optim.optimiser.set_learning_rate(eta=[11, 4.5])

Expand Down
Loading